Skip to content

Commit 2915714

Browse files
committed
fix: oops vendor string embedded in version
Signed-off-by: Josh Richards <[email protected]>
1 parent 7d7ae25 commit 2915714

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

apps/settings/lib/SetupChecks/SupportedDatabase.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,13 +64,13 @@ public function run(): SetupResult {
6464
$versionlc = strtolower($version);
6565
// we only care about X.Y not X.Y.Z differences
6666
[$major, $minor, ] = explode('.', $versionlc);
67-
$versionlc = $major . '.' . $minor;
67+
$versionConcern = $major . '.' . $minor;
6868
if (str_contains($versionlc, 'mariadb')) {
69-
if (version_compare($versionlc, '10.3', '<') || version_compare($versionlc, '10.11', '>')) {
69+
if (version_compare($versionConcern, '10.3', '<') || version_compare($versionConcern, '10.11', '>')) {
7070
return SetupResult::warning($this->l10n->t('MariaDB version "%s" detected. MariaDB >=10.3 and <=10.11 is suggested for best performance, stability and functionality with this version of Nextcloud.', $version));
7171
}
7272
} else {
73-
if (version_compare($versionlc, '8.0', '<') || version_compare($versionlc, '8.3', '>')) {
73+
if (version_compare($versionConcern, '8.0', '<') || version_compare($versionConcern, '8.3', '>')) {
7474
return SetupResult::warning($this->l10n->t('MySQL version "%s" detected. MySQL >=8.0 and <=8.3 is suggested for best performance, stability and functionality with this version of Nextcloud.', $version));
7575
}
7676
}
@@ -82,8 +82,8 @@ public function run(): SetupResult {
8282
$versionlc = strtolower($version);
8383
// we only care about X not X.Y or X.Y.Z differences
8484
[$major, ] = explode('.', $versionlc);
85-
$versionlc = $major;
86-
if (version_compare($versionlc, '12', '<') || version_compare($versionlc, '16', '>')) {
85+
$versionConcern = $major;
86+
if (version_compare($versionConcern, '12', '<') || version_compare($versionConcern, '16', '>')) {
8787
return SetupResult::warning($this->l10n->t('PostgreSQL version "%s" detected. PostgreSQL >=12 and <=16 is suggested for best performance, stability and functionality with this version of Nextcloud.', $version));
8888
}
8989
} elseif ($databasePlatform instanceof OraclePlatform) {

0 commit comments

Comments
 (0)