fix(contacts): Do not expose SAB in /contactsmenu

When hitting the `/contactsmenu/contacts` endpoint with the `dav.system_addressbook_exposed` config switch set to `"no"`, the system address book content is still listed in the response.

This ensure that we do not expose unexpectedly the system address book.

Signed-off-by: Louis Chemineau <[email protected]>

[skip ci]

Author: artonge

apps/dav/lib/CardDAV/ContactsManager.php

@@ -26,6 +26,7 @@
 namespace OCA\DAV\CardDAV;
 
 use OCP\Contacts\IManager;
+use OCP\IAppConfig;
 use OCP\IL10N;
 use OCP\IURLGenerator;
 

apps/dav/tests/unit/CardDAV/ContactsManagerTest.php

@@ -28,6 +28,7 @@
 use OCA\DAV\CardDAV\CardDavBackend;
 use OCA\DAV\CardDAV\ContactsManager;
 use OCP\Contacts\IManager;
+use OCP\IAppConfig;
 use OCP\IL10N;
 use OCP\IURLGenerator;
 use Test\TestCase;
@@ -44,6 +45,7 @@ public function test(): void {
 			['{DAV:}displayname' => 'Test address book', 'uri' => 'default'],
 		]);
 
+		/** @var IL10N&MockObject $l */
 		$l = $this->createMock(IL10N::class);
 		$app = new ContactsManager($backEnd, $l);
 		$app->setupContactsProvider($cm, 'user01', $urlGenerator);

build/integration/features/contacts-menu.feature

@@ -192,3 +192,19 @@ Feature: contacts-menu
     And searching for contacts matching with "test"
     # Disabled because it regularly fails on drone:
     # Then the list of searched contacts has "0" contacts
+
+  Scenario: users cannot list other users from the system address book
+    Given user "user0" exists
+    And user "user1" exists
+    And invoking occ with "config:app:set dav system_addressbook_exposed --value false"
+    And Logging in using web as "user1"
+    And searching for contacts matching with ""
+    Then the list of searched contacts has "1" contacts
+    And invoking occ with "config:app:delete dav system_addressbook_exposed"
+
+  Scenario: users can list other users from the system address book
+    Given user "user0" exists
+    And user "user1" exists
+    And Logging in using web as "user1"
+    And searching for contacts matching with ""
+    Then the list of searched contacts has "2" contacts