Merge pull request #55725 from nextcloud/backport/55658/stable31

[stable31] fix: disable mp3 preview provider

Author: kesselb

config/config.sample.php

@@ -1277,16 +1277,14 @@
 /**
  * Previews
  *
- * Nextcloud supports previews of image files, the covers of MP3 files, and text
- * files. These options control enabling and disabling previews, and thumbnail
- * size.
+ * Nextcloud supports generating previews for various file types, such as images, audio files, and text files.
+ * These options control enabling and disabling previews, and thumbnail size.
  */
 
 /**
  * By default, Nextcloud can generate previews for the following filetypes:
  *
  * - Image files
- * - Covers of MP3 files
  * - Text documents
  *
  * Valid values are ``true``, to enable previews, or
@@ -1392,21 +1390,21 @@
  * The following providers are disabled by default due to performance or privacy
  * concerns:
  *
+ *  - ``OC\Preview\EMF``
  *  - ``OC\Preview\Font``
  *  - ``OC\Preview\HEIC``
  *  - ``OC\Preview\Illustrator``
- *  - ``OC\Preview\Movie``
+ *  - ``OC\Preview\MP3``
  *  - ``OC\Preview\MSOffice2003``
  *  - ``OC\Preview\MSOffice2007``
  *  - ``OC\Preview\MSOfficeDoc``
+ *  - ``OC\Preview\Movie``
  *  - ``OC\Preview\PDF``
  *  - ``OC\Preview\Photoshop``
  *  - ``OC\Preview\Postscript``
- *  - ``OC\Preview\StarOffice``
  *  - ``OC\Preview\SVG``
+ *  - ``OC\Preview\StarOffice``
  *  - ``OC\Preview\TIFF``
- *  - ``OC\Preview\EMF``
- *
  *
  * Defaults to the following providers:
  *
@@ -1415,19 +1413,18 @@
  *  - ``OC\Preview\JPEG``
  *  - ``OC\Preview\Krita``
  *  - ``OC\Preview\MarkDown``
- *  - ``OC\Preview\MP3``
  *  - ``OC\Preview\OpenDocument``
  *  - ``OC\Preview\PNG``
  *  - ``OC\Preview\TXT``
  *  - ``OC\Preview\XBitmap``
+ *
  */
 'enabledPreviewProviders' => [
 	'OC\Preview\BMP',
 	'OC\Preview\GIF',
 	'OC\Preview\JPEG',
 	'OC\Preview\Krita',
 	'OC\Preview\MarkDown',
-	'OC\Preview\MP3',
 	'OC\Preview\OpenDocument',
 	'OC\Preview\PNG',
 	'OC\Preview\TXT',

lib/private/PreviewManager.php

@@ -251,29 +251,29 @@ public function isAvailable(\OCP\Files\FileInfo $file, ?string $mimeType = null)
 	 * List of enabled default providers
 	 *
 	 * The following providers are enabled by default:
-	 *  - OC\Preview\PNG
-	 *  - OC\Preview\JPEG
-	 *  - OC\Preview\GIF
 	 *  - OC\Preview\BMP
-	 *  - OC\Preview\XBitmap
+	 *  - OC\Preview\GIF
+	 *  - OC\Preview\JPEG
 	 *  - OC\Preview\MarkDown
-	 *  - OC\Preview\MP3
+	 *  - OC\Preview\PNG
 	 *  - OC\Preview\TXT
+	 *  - OC\Preview\XBitmap
 	 *
 	 * The following providers are disabled by default due to performance or privacy concerns:
 	 *  - OC\Preview\Font
 	 *  - OC\Preview\HEIC
 	 *  - OC\Preview\Illustrator
-	 *  - OC\Preview\Movie
-	 *  - OC\Preview\MSOfficeDoc
+	 *  - OC\Preview\MP3
 	 *  - OC\Preview\MSOffice2003
 	 *  - OC\Preview\MSOffice2007
+	 *  - OC\Preview\MSOfficeDoc
+	 *  - OC\Preview\Movie
 	 *  - OC\Preview\OpenDocument
 	 *  - OC\Preview\PDF
 	 *  - OC\Preview\Photoshop
 	 *  - OC\Preview\Postscript
-	 *  - OC\Preview\StarOffice
 	 *  - OC\Preview\SVG
+	 *  - OC\Preview\StarOffice
 	 *  - OC\Preview\TIFF
 	 *
 	 * @return array
@@ -295,7 +295,6 @@ protected function getEnabledDefaultProvider() {
 
 		$this->defaultProviders = $this->config->getSystemValue('enabledPreviewProviders', array_merge([
 			Preview\MarkDown::class,
-			Preview\MP3::class,
 			Preview\TXT::class,
 			Preview\OpenDocument::class,
 		], $imageProviders));