App updater doesn't error out when app store requests fail

[jonas2515]

When upgrading nextcloud, the app updater tries to update the apps. For that it does requests to the apps.nextcloud.org API, in particular to https://apps.nextcloud.com/api/v1/apps.json.

This API is rate limited to only very few requests per hour, and after about 20 requests a HTTP error code (429 Too Many Requests) is returned.

The nextcloud app updater doesn't parse that error code, and instead simply continues and pretends no updates are available.

When this is happening during a NC major version upgrade, all 3rd party apps get disabled as incompatible during the upgrade, then the updater doesn't find a new (compatible) version and the apps are kept disabled, leaving the installation without 3rd party apps after the upgrade.

[LordArrin]

Same thing here. Cant't use app store in my server

[jonas2515]

ping @come-nc

[come-nc]

This is harder to fix than I thought, the app fetcher is logging the error and continuing, and in a lot of cases that’s good enough.
So we’d need to special case instance upgrade I believe.