Skip to content

Conversation

@kesselb
Copy link
Collaborator

@kesselb kesselb commented Jul 1, 2025

Summary

Making the log messages regarding imip processing more useful by including additional context.

Examples of the current state / without this patch

{
  "reqId": "...",
  "level": 2,
  "time": "...",
  "remoteAddr": "",
  "user": "--",
  "app": "no app in context",
  "method": "",
  "url": "--",
  "message": "iMip message event could not be processed because recipient and ORGANIZER must be identical",
  "userAgent": "--",
  "version": "...",
  "data": []
}
{
  "reqId": "...",
  "level": 2,
  "time": "...",
  "remoteAddr": "",
  "user": "--",
  "app": "no app in context",
  "method": "",
  "url": "--",
  "message": "iMip message event dose not contains an organizer",
  "userAgent": "--",
  "version": "...",
  "data": []
}
{
  "reqId": "...",
  "level": 2,
  "time": "...",
  "remoteAddr": "",
  "user": "--",
  "app": "no app in context",
  "method": "",
  "url": "--",
  "message": "iMip message event does not contain a attendee that matches the recipient",
  "userAgent": "--",
  "version": "...",
  "data": []
}

TODO

  • Manual testing

Checklist

@kesselb kesselb requested a review from ChristophWurst July 1, 2025 14:00
$logContext = [
'principalUri' => $principalUri,
'sender' => $sender,
'recipient' => $recipient,
Copy link
Collaborator Author

@kesselb kesselb Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be useful to know the sender/recipient. But principalUri and event UID (if applicable) might be enough for a start.

Context: The code is processing an imip message. That might be an reply from an external person for a calender invitation or a locall user sending out invitations.

@kesselb kesselb self-assigned this Jul 1, 2025
@kesselb kesselb added this to the Nextcloud 32 milestone Jul 1, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants