Skip to content

Commit c5942fe

Browse files
authored
Merge pull request #5111 from nextcloud/improve_accessibility
Improve accessibility
2 parents 4667fef + c208b3d commit c5942fe

File tree

4 files changed

+11
-7
lines changed

4 files changed

+11
-7
lines changed

app/src/main/res/layout/call_activity.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@
298298
android:layout_width="wrap_content"
299299
android:layout_height="wrap_content"
300300
android:layout_margin="@dimen/standard_quarter_margin"
301-
android:contentDescription="@string/nc_call_button_content_description_microphone"
301+
android:contentDescription="@string/nc_common_more_options"
302302
app:backgroundTint="@color/call_buttons_background"
303303
app:borderWidth="0dp"
304304
app:fabCustomSize="40dp"
@@ -311,7 +311,7 @@
311311
android:layout_width="wrap_content"
312312
android:layout_height="wrap_content"
313313
android:layout_margin="@dimen/standard_quarter_margin"
314-
android:contentDescription="@string/nc_call_button_content_description_microphone"
314+
android:contentDescription="@string/end_call"
315315
app:backgroundTint="@color/nc_darkRed"
316316
app:borderWidth="0dp"
317317
app:fabCustomSize="40dp"

app/src/main/res/layout/fragment_message_input_voice_recording.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@
8080
android:layout_marginVertical="@dimen/standard_margin"
8181
android:scaleType="centerInside"
8282
android:src="@drawable/ic_delete"
83-
android:contentDescription="@null"
83+
android:contentDescription="@string/delete_voice_recording"
8484
android:background="?android:attr/selectableItemBackgroundBorderless"
8585
android:layout_weight="1"
8686
/>
@@ -103,7 +103,7 @@
103103
android:layout_marginVertical="@dimen/standard_margin"
104104
android:scaleType="centerInside"
105105
android:src="@drawable/ic_send"
106-
android:contentDescription="@null"
106+
android:contentDescription="@string/nc_send_voice_recording"
107107
android:background="?android:attr/selectableItemBackgroundBorderless"
108108
android:layout_weight="1"
109109
/>

app/src/main/res/layout/view_message_input.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@
116116
android:layout_marginStart="@dimen/standard_double_margin"
117117
android:scaleType="centerInside"
118118
android:src="@drawable/ic_delete"
119-
android:contentDescription="@null"
119+
android:contentDescription="@string/delete_voice_recording"
120120
android:background="?android:attr/selectableItemBackgroundBorderless"
121121
android:visibility="gone" />
122122

@@ -131,7 +131,7 @@
131131
android:layout_marginEnd="@dimen/standard_double_margin"
132132
android:scaleType="centerInside"
133133
android:src="@drawable/ic_send"
134-
android:contentDescription="@null"
134+
android:contentDescription="@string/nc_send_voice_recording"
135135
android:background="?android:attr/selectableItemBackgroundBorderless"
136136
android:visibility="gone" />
137137

@@ -147,7 +147,7 @@
147147
android:scaleType="centerInside"
148148
android:layout_alignParentStart="true"
149149
android:src="@drawable/ic_baseline_mic_red_24"
150-
android:contentDescription="@null"
150+
android:contentDescription="@string/nc_microphone_enabled_audio_recording"
151151
android:visibility="gone"
152152
tools:visibility="gone" />
153153

app/src/main/res/values/strings.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -299,6 +299,7 @@ How to translate with transifex:
299299
<string name="nc_camera_permission_hint">To enable video communication please grant \"Camera\" permission.</string>
300300
<string name="nc_microphone_permission_hint">To enable voice communication please grant \"Microphone\" permission.</string>
301301
<string name="nc_bluetooth_permission_hint">To enable bluetooth speakers please grant \"Nearby devices\" permission.</string>
302+
<string name="nc_microphone_enabled_audio_recording">Microphone is enabled and audio is recording</string>
302303

303304
<!-- Call -->
304305
<string name="nc_call_voice">%s voice call</string>
@@ -332,6 +333,7 @@ How to translate with transifex:
332333
<string name="call_running_since_one_hour">The call has been running for one hour.</string>
333334
<string name="end_call_for_everyone">End call for everyone</string>
334335
<string name="leave_call">Leave call</string>
336+
<string name="end_call">End call</string>
335337

336338
<!-- Picture in Picture -->
337339
<string name="nc_pip_microphone_mute">Mute microphone</string>
@@ -451,6 +453,7 @@ How to translate with transifex:
451453
<item quantity="one">See %d similar message</item>
452454
<item quantity="other">See %d similar messages</item>
453455
</plurals>
456+
<string name="nc_send_voice_recording">Send voice recording</string>
454457

455458
<!-- Conversation info guest access -->
456459
<string name="nc_guest_access">Guest access</string>
@@ -591,6 +594,7 @@ How to translate with transifex:
591594
<string name="play_pause_voice_message">Play/pause voice message</string>
592595
<string name="nc_voice_message_missing_audio_permission">Permission for audio recording is required</string>
593596
<string name="playback_speed_control">Playback speed control</string>
597+
<string name="delete_voice_recording">Delete voice recording</string>
594598

595599
<!-- Phonebook Integration -->
596600
<string name="nc_settings_phone_book_integration_desc">Match contacts based on phone number to integrate Talk shortcut into system contacts app</string>

0 commit comments

Comments
 (0)