Invoke workflow complete handler on all workflow errors (#4299)

Signed-off-by: Ben Sherman <[email protected]>
Co-authored-by: Jorge Ejarque <[email protected]>

Author: bentsherman

modules/nextflow/src/main/groovy/nextflow/Session.groovy

@@ -811,8 +811,10 @@ class Session implements ISession {
             // dump threads status
             if( log.isTraceEnabled() )
                 log.trace(SysHelper.dumpThreads())
-            // force termination
+            // invoke shutdown callbacks
+            shutdown0()
             notifyError(null)
+            // force termination
             ansiLogObserver?.forceTermination()
             executorFactory?.signalExecutors()
             processesBarrier.forceTermination()

tests/checks/workflow-oncomplete-error.nf/.checks

@@ -0,0 +1,7 @@
+set -e
+
+echo ''
+$NXF_RUN > stdout || true
+
+[[ `grep -c 'workflow onComplete: false' stdout` == 1 ]] || false
+[[ `grep -c 'workflow onError: Not enough values!' stdout` == 1 ]] || false

tests/workflow-oncomplete-error.nf

@@ -0,0 +1,33 @@
+#!/usr/bin/env nextflow
+/*
+ * Copyright 2013-2024, Seqera Labs
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+workflow {
+  channel.of(1, 2, 3)
+    .collect()
+    .subscribe { values ->
+      if( values.size() < 10 )
+        error 'Not enough values!'
+    }
+
+  workflow.onComplete = {
+    println "workflow onComplete: ${workflow.success}"
+  }
+
+  workflow.onError = {
+    println "workflow onError: ${workflow.errorMessage}"
+  }
+}