-
Notifications
You must be signed in to change notification settings - Fork 744
Add platform-related metadata in Lineage records #6545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: jorgee <[email protected]>
Signed-off-by: jorgee <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
modules/nextflow/src/main/groovy/nextflow/script/PlatformMetadata.groovy
Show resolved
Hide resolved
plugins/nf-tower/src/main/io/seqera/tower/plugin/BaseCommandImpl.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: jorgee <[email protected]>
Signed-off-by: jorgee <[email protected]>
…ation Signed-off-by: jorgee <[email protected]>
Signed-off-by: jorgee <[email protected]>
|
Updates: Regarding increasing the version, I have tested reading WorkflowRun generated with this PR with 25.10.0 and olded versions and viceversa.
Apart form that, a minor comment is that there are some duplicated data such as run name, session id, repository, script files or revision. They are already |
| void setCommonApi( TowerCommonApi commonApi ){ | ||
| this.commonApi = commonApi | ||
| } | ||
| /** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would not make sense to pass both TowerCommonApi and HxClient via the constructor?
close #5077
This PR retrieves the platform metada during the
onWorkflowCreateand stores in theseqeraPlatformproperty in theWorkflowMetadataclass. The lineage module has been extended adding ametadatafield in theWorkflowRunrecord including the platform metadata.This PR includes the changes of #6069.
To tests the whole integration, it is required to generate a nf-launcher image with the nextflow changes as in e2e tests. Then , use
tw launchto run a workflow including the options to use a modified launcher image (--launcher-image) and a nextflow.config file (--config) with the following lineage configurationUse a
<bucket>associated to the CE running the pipeline to ensure you have the proper permissions.Once finished, you can use the nextflow lineage commands to inspect the workflow lineage records.
Example of the generated metadata extracted form a test execution:
TODO: