-
Notifications
You must be signed in to change notification settings - Fork 4
Reports fraser mae #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
it seems maeqc report have different result compared to snakemake results otherwise it is ready for review |
conf/modules.config
Outdated
| case 'versions.yml': | ||
| null | ||
| break | ||
| case ~/\[TAG:.+\]_multiqc_(report\.html|plots|data)/: | ||
| def tag = (filename =~ /\[TAG:(.+)\]_multiqc_(report\.html|plots|data)/)[0][1] | ||
| case ~/\[TAG:genecounts_.+\]_multiqc_(report_mqc\.html|plots|data)/: | ||
| def tag = (filename =~ /\[TAG:genecounts_(.+)\]_multiqc_(report_mqc\.html|plots|data)/)[0][1] | ||
| def new_filename = filename.replaceFirst( | ||
| "(?<prefix>.*)\\[TAG:${tag}\\]_(?<suffix>multiqc_(report\\.html|plots|data).*)", | ||
| "(?<prefix>.*)\\[TAG:genecounts_${tag}\\]_(?<suffix>multiqc_(report_mqc\\.html|plots|data).*)", | ||
| '${prefix}${suffix}') | ||
| "${tag}/${new_filename}" | ||
| break |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switch case statements are no longer supported in configs by nextflow, can you migrate this to if-statements?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't you have all reports in one Multiqc report? Or is there some technical issue I don't know about? :p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mainly followed the way as it was, one report per group per subworkflow. With this there are already quite a few plots and info. QC of different subworkflow, for example, is quite different. I agree with Phil's comment in slack multiqc channel that reorganizing data and channel will help have everything in one multiqc report but currently I am not sure how other think to have some many things in one page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, fine by me. We don't need to fix or reinvent things now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Uh oh!
There was an error while loading. Please reload this page.