Skip to content

Conversation

@fulaibaowang
Copy link
Contributor

@fulaibaowang fulaibaowang commented Aug 28, 2025

  • reports for as and mae
  • use native multiqc to merge all reports from ae, as and mae

@fulaibaowang fulaibaowang marked this pull request as ready for review August 29, 2025 14:58
@fulaibaowang
Copy link
Contributor Author

fulaibaowang commented Aug 29, 2025

it seems maeqc report have different result compared to snakemake results otherwise it is ready for review

Comment on lines 343 to 352
case 'versions.yml':
null
break
case ~/\[TAG:.+\]_multiqc_(report\.html|plots|data)/:
def tag = (filename =~ /\[TAG:(.+)\]_multiqc_(report\.html|plots|data)/)[0][1]
case ~/\[TAG:genecounts_.+\]_multiqc_(report_mqc\.html|plots|data)/:
def tag = (filename =~ /\[TAG:genecounts_(.+)\]_multiqc_(report_mqc\.html|plots|data)/)[0][1]
def new_filename = filename.replaceFirst(
"(?<prefix>.*)\\[TAG:${tag}\\]_(?<suffix>multiqc_(report\\.html|plots|data).*)",
"(?<prefix>.*)\\[TAG:genecounts_${tag}\\]_(?<suffix>multiqc_(report_mqc\\.html|plots|data).*)",
'${prefix}${suffix}')
"${tag}/${new_filename}"
break
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switch case statements are no longer supported in configs by nextflow, can you migrate this to if-statements?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed accordingly

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you have all reports in one Multiqc report? Or is there some technical issue I don't know about? :p

Copy link
Contributor Author

@fulaibaowang fulaibaowang Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mainly followed the way as it was, one report per group per subworkflow. With this there are already quite a few plots and info. QC of different subworkflow, for example, is quite different. I agree with Phil's comment in slack multiqc channel that reorganizing data and channel will help have everything in one multiqc report but currently I am not sure how other think to have some many things in one page.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, fine by me. We don't need to fix or reinvent things now :)

Copy link
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fulaibaowang fulaibaowang merged commit 38835fb into nf-core:dev Sep 8, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants