General: add pytest for get_wf_files

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 ### General
 
+- add pytest for get_wf_files ([#3725](https://github.com/nf-core/tools/pull/3725))
 - Update GitHub Actions (major) ([#3849](https://github.com/nf-core/tools/pull/3849))
 - add optional link to blogpost to sync PR ([#3852](https://github.com/nf-core/tools/pull/3852))
 - update multiqc version to fix utils test ([#3853](https://github.com/nf-core/tools/pull/3853))

nf_core/utils.py

@@ -1647,13 +1647,18 @@ def get_wf_files(wf_path: Path):
     """Return a list of all files in a directory (ignores .gitigore files)"""
 
     wf_files = []
-
     try:
         with open(Path(wf_path, ".gitignore")) as f:
             lines = f.read().splitlines()
-        ignore = [line for line in lines if line and not line.startswith("#")]
+            print(lines)
+        ignore = [
+            (str(wf_path / line) + "*" if line.endswith("/") else str(wf_path / line))
+            for line in lines
+            if line and not line.startswith("#")
+        ]
     except FileNotFoundError:
         ignore = []
+    print(ignore)
 
     for path in Path(wf_path).rglob("*"):
         if any(fnmatch.fnmatch(str(path), pattern) for pattern in ignore):

tests/test_utils.py

@@ -212,10 +212,10 @@ def test_set_wd(self):
 
     def test_set_wd_revert_on_raise(self):
         wd_before_context = Path().resolve()
-        with pytest.raises(Exception):
-            with nf_core.utils.set_wd(self.tmp_dir):
-                raise Exception
-        assert wd_before_context == Path().resolve()
+        with mock.patch("nf_core.utils.set_wd", side_effect=Exception("mocked exception")):
+            with pytest.raises(Exception):
+                with nf_core.utils.set_wd(self.tmp_dir):
+                    assert wd_before_context == Path().resolve()
 
     @mock.patch("nf_core.utils.run_cmd")
     def test_fetch_wf_config(self, mock_run_cmd):
@@ -224,3 +224,16 @@ def test_fetch_wf_config(self, mock_run_cmd):
         config = nf_core.utils.fetch_wf_config(".", False)
         assert len(config.keys()) == 1
         assert "params.param2" in list(config.keys())
+
+    def test_get_wf_files(self):
+        (self.pipeline_obj.wf_path / "work").mkdir()
+        (self.pipeline_obj.wf_path / "work" / "file.txt").touch()
+        (self.pipeline_obj.wf_path / ".nextflow.log").touch()
+        files = nf_core.utils.get_wf_files(self.pipeline_obj.wf_path)
+        assert str(Path(self.pipeline_dir, "main.nf")) in files
+        assert str(Path(self.pipeline_dir, "work", "file.txt")) not in files
+        assert str(Path(self.pipeline_dir, ".nextflow.log")) not in files
+
+    def test_get_wf_files_no_gitignore(self):
+        files = nf_core.utils.get_wf_files(Path("random/path"))
+        assert files == []