Skip to content

Commit 7608d7a

Browse files
mjangsylwang
andcommitted
Apply suggestions from code review
Co-authored-by: Sylvia Wang <[email protected]>
1 parent 5b5bf13 commit 7608d7a

File tree

2 files changed

+8
-11
lines changed

2 files changed

+8
-11
lines changed

content/nginx-one/k8s/add-nic.md

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ Connecting NGINX Ingress Controller to NGINX One Console enables centralized mon
1212
Once connected, you'll see a **read-only** configuration of NGINX Ingress Controller. For each instance, you can review:
1313

1414
- Read-only configuration file
15-
- SSL/TLS certificates
16-
- CVEs
15+
- Unmanaged SSL/TLS certificates for Control Planes
1716

1817
## Before you begin
1918

@@ -43,7 +42,7 @@ Edit your `values.yaml` file to enable NGINX Agent and configure it to connect t
4342
```yaml
4443
nginxAgent:
4544
enable: true
46-
dataplaneKeySecretName: "<Your Dataplane Key Secret Name>"
45+
dataplaneKeySecretName: "<data_plane_key_secret_name>"
4746
```
4847
4948
The `dataplaneKeySecretName` is used to authenticate the agent with NGINX One Console. See the [NGINX One Console Docs]({{< ref "/nginx-one/connect-instances/create-manage-data-plane-keys.md" >}})
@@ -99,7 +98,7 @@ data:
9998
```
10099

101100
Make sure to set the namespace in the nginx-agent.config to the same namespace as NGINX Ingress Controller.
102-
Mount the ConfigMap to the deployment/daemonset file of NGINX Ingress Controller:
101+
Mount the ConfigMap to the Deployment/DaemonSet file of NGINX Ingress Controller:
103102

104103
```yaml
105104
volumeMounts:
@@ -114,7 +113,7 @@ volumes:
114113
name: nginx-agent-config
115114
- name: dataplane-key
116115
secret:
117-
secretName: <Your Dataplane Key Secret Name>
116+
secretName: "<data_plane_key_secret_name>"
118117
```
119118

120119
Follow the [Installation with Manifests]({{< ref "/nic/installation/installing-nic/installation-with-manifests.md" >}}) instructions to deploy NGINX Ingress Controller.
@@ -134,7 +133,7 @@ If you encounter issues connecting your instances to NGINX One Console, try the
134133
Check the NGINX Agent version:
135134

136135
```shell
137-
kubectl exec -it -n <namespace> <nginx-ingress-pod-name> -- nginx-agent -v
136+
kubectl exec -it -n <namespace> <nginx_ingress_pod_name> -- nginx-agent -v
138137
```
139138

140139
If nginx-agent version is v3, continue with the following steps.
@@ -143,19 +142,18 @@ Otherwise, make sure you are using an image that does not include NGINX App Prot
143142
Check the NGINX Agent configuration:
144143

145144
```shell
146-
kubectl exec -it -n <namespace> <nginx-ingress-pod-name> -- cat /etc/nginx-agent/nginx-agent.conf
145+
kubectl exec -it -n <namespace> <nginx_ingress_pod_name> -- cat /etc/nginx-agent/nginx-agent.conf
147146
```
148147

149148
Check NGINX Agent logs:
150149

151150
```shell
152-
kubectl exec -it -n <namespace> <nginx-ingress-pod-name> -- nginx-agent
151+
kubectl exec -it -n <namespace> <nginx_ingress_pod_name> -- nginx-agent
153152
```
154153

155-
Select the instance associated with your deployment of NGINX Ingress Controller. Under the **Details** tab, you'll see You'll see information associated with:
154+
Select the instance associated with your deployment of NGINX Ingress Controller. Under the **Details** tab, you'll see information associated with:
156155

157156
- SSL/TLS certificates
158-
- CVEs
159157
- Configuration recommendations
160158

161159
Under the **Configuration** tab, you'll see a **read-only** view of the configuration files.

content/nginx-one/k8s/overview.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,5 @@ nd-product: NGINX One
1515
You can now include Kubernetes systems through the [control plane](https://www.f5.com/glossary/control-plane). In related documentation, you can learn how to:
1616

1717
- Set up a connection to F5 NGINX One Console through a data plane key.
18-
- Monitor each connected Kubernetes system for CVEs.
1918
- Review the NGINX Ingress Controller instances that are part of your fleet.
2019

0 commit comments

Comments
 (0)