NLB-6293 Upgraded golangci-lint to v1.64.5 and fixed configuration

Author: arussellf5

.golangci.yml

@@ -26,7 +26,6 @@ linters:
     - misspell
     - nakedret
     - prealloc
-    - exportloopref
     - stylecheck
     - unconvert
     - unparam
@@ -38,20 +37,17 @@ linters:
 run:
   # 10 minute timeout for analysis
   timeout: 10m
-  skip-dirs-use-default: true
-  skip-dirs:
-    - .go/pkg/mod
-    - pkg/spec/api # Generated code
-    - vendor
-    - vendor-fork
 # Specific linter settings
 linters-settings:
   gocyclo:
     # Minimal code complexity to report
     min-complexity: 16
   govet:
-    # Report shadowed variables
-    check-shadowing: true
+    disable-all: true
+    enable:
+      # Report shadowed variables
+      - shadow
+
   misspell:
     # Correct spellings using locale preferences for US
     locale: US
@@ -63,8 +59,8 @@ linters-settings:
     # If this list is empty, all structs are tested.
     # Default: []
     include:
-      - 'gitlab.com/f5/nginx/nginxazurelb/azure-resource-provider/pkg/token.TokenID'
-      - 'gitlab.com/f5/nginx/nginxazurelb/azure-resource-provider/internal/dpo/agent/certificates.CertGetRequest'
+      - "gitlab.com/f5/nginx/nginxazurelb/azure-resource-provider/pkg/token.TokenID"
+      - "gitlab.com/f5/nginx/nginxazurelb/azure-resource-provider/internal/dpo/agent/certificates.CertGetRequest"
 
 issues:
   # Exclude configuration

cmd/nginx-loadbalancer-kubernetes/main.go

@@ -133,9 +133,13 @@ func buildKubernetesClient() (*kubernetes.Clientset, error) {
 	return client, nil
 }
 
+// TODO: NLB-6294 change to use new typed workqueues
+//
+//nolint:staticcheck //ignore deprecation warnings
 func buildWorkQueue(settings configuration.WorkQueueSettings) workqueue.RateLimitingInterface {
 	slog.Debug("Watcher::buildSynchronizerWorkQueue")
 
+	//nolint:staticcheck //ignore deprecation warnings
 	rateLimiter := workqueue.NewItemExponentialFailureRateLimiter(settings.RateLimiterBase, settings.RateLimiterMax)
 	return workqueue.NewNamedRateLimitingQueue(rateLimiter, settings.Name)
 }

internal/synchronization/synchronizer.go

@@ -50,6 +50,8 @@ type ServiceKey struct {
 // a Border Client as specified in the Service annotation for the Upstream.
 // See application/border_client.go and application/application_constants.go for details.
 type Synchronizer struct {
+	// TODO: NLB-6294 change to use new typed workqueues
+	//nolint:staticcheck //ignore deprecation warnings
 	eventQueue    workqueue.RateLimitingInterface
 	settings      configuration.Settings
 	translator    Translator
@@ -60,6 +62,7 @@ type Synchronizer struct {
 // NewSynchronizer creates a new Synchronizer.
 func NewSynchronizer(
 	settings configuration.Settings,
+	//nolint:staticcheck //ignore deprecation warnings
 	eventQueue workqueue.RateLimitingInterface,
 	translator Translator,
 	serviceLister corelisters.ServiceLister,