NH-4008 - Mark all usages of obsolete drivers so there's no errors.

ngbrown · ngbrown · commit e19b3c2f53a2 · 2018-03-13T10:30:14.000-07:00
diff --git a/src/NHibernate.Test/Async/DriverTest/FirebirdClientDriverFixture.cs b/src/NHibernate.Test/Async/DriverTest/FirebirdClientDriverFixture.cs
@@ -21,6 +21,7 @@ namespace NHibernate.Test.DriverTest
 	using System.Threading.Tasks;
 	using System.Threading;
 	[TestFixture]
+	[Obsolete("Uses old driver")]
 	public class FirebirdClientDriverFixtureAsync
 	{
 		private string _connectionString;
diff --git a/src/NHibernate.Test/Async/Futures/FallbackFixture.cs b/src/NHibernate.Test/Async/Futures/FallbackFixture.cs
@@ -8,6 +8,7 @@
 //------------------------------------------------------------------------------
 
 
+using System;
 using System.Linq;
 using NHibernate.Cfg;
 using NHibernate.Connection;
@@ -31,6 +32,7 @@ namespace NHibernate.Test.Futures
 	/// but this way it's just much easier to test this
 	/// </summary>
 	[TestFixture]
+	[Obsolete("Uses old driver")]
 	public class FallbackFixtureAsync : FutureFixture
 	{
 		protected override bool AppliesTo(Dialect.Dialect dialect)
diff --git a/src/NHibernate.Test/Async/NHSpecificTest/NH2660And2661/Test.cs b/src/NHibernate.Test/Async/NHSpecificTest/NH2660And2661/Test.cs
@@ -18,6 +18,7 @@ namespace NHibernate.Test.NHSpecificTest.NH2660And2661
 {
 	using System.Threading.Tasks;
 	[TestFixture]
+	[Obsolete("Uses old driver")]
 	public class TestAsync : BugTestCase
 	{
 		protected override void OnSetUp()
diff --git a/src/NHibernate.Test/Async/NHSpecificTest/NH3202/Fixture.cs b/src/NHibernate.Test/Async/NHSpecificTest/NH3202/Fixture.cs
@@ -8,18 +8,21 @@
 //------------------------------------------------------------------------------
 
 
+using System;
 using System.Data.Common;
 using System.Text.RegularExpressions;
 using NHibernate.Cfg;
 using NHibernate.Dialect;
 using NHibernate.Driver;
 using NHibernate.Util;
 using NUnit.Framework;
+using Environment = NHibernate.Cfg.Environment;
 
 namespace NHibernate.Test.NHSpecificTest.NH3202
 {
 	using System.Threading.Tasks;
 	[TestFixture]
+	[Obsolete("Uses old driver")]
 	public class FixtureAsync : BugTestCase
 	{
 		protected override void Configure(Configuration configuration)
diff --git a/src/NHibernate.Test/Async/Pagination/CustomDialectFixture.cs b/src/NHibernate.Test/Async/Pagination/CustomDialectFixture.cs
@@ -8,6 +8,7 @@
 //------------------------------------------------------------------------------
 
 
+using System;
 using System.Collections;
 using System.Collections.Generic;
 using NHibernate.Cfg;
@@ -21,6 +22,7 @@ namespace NHibernate.Test.Pagination
 {
 	using System.Threading.Tasks;
 	[TestFixture]
+	[Obsolete("Uses old driver")]
 	public class CustomDialectFixtureAsync : TestCase
 	{
 		protected override string MappingsAssembly
diff --git a/src/NHibernate.Test/CfgTest/Loquacious/ConfigurationFixture.cs b/src/NHibernate.Test/CfgTest/Loquacious/ConfigurationFixture.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Data;
 using System.Data.SqlClient;
 using System.IO;
@@ -12,13 +13,15 @@
 using NHibernate.Linq;
 using NHibernate.Type;
 using NUnit.Framework;
+using Environment = NHibernate.Cfg.Environment;
 
 namespace NHibernate.Test.CfgTest.Loquacious
 {
 	[TestFixture]
 	public class ConfigurationFixture
 	{
 		[Test]
+		[Obsolete("Uses old driver")]
 		public void CompleteConfiguration()
 		{
 			const string connectionString = "The connection string";
diff --git a/src/NHibernate.Test/CfgTest/Loquacious/LambdaConfigurationFixture.cs b/src/NHibernate.Test/CfgTest/Loquacious/LambdaConfigurationFixture.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Data;
 using NHibernate.AdoNet;
 using NHibernate.Bytecode;
@@ -10,13 +11,15 @@
 using NHibernate.Type;
 using NUnit.Framework;
 using NHibernate.Exceptions;
+using Environment = NHibernate.Cfg.Environment;
 
 namespace NHibernate.Test.CfgTest.Loquacious
 {
 	[TestFixture]
 	public class LambdaConfigurationFixture
 	{
 		[Test]
+		[Obsolete("Uses old driver")]
 		public void FullConfiguration()
 		{
 			var configure = new Configuration();
diff --git a/src/NHibernate.Test/DriverTest/FirebirdClientDriverFixture.cs b/src/NHibernate.Test/DriverTest/FirebirdClientDriverFixture.cs
@@ -9,6 +9,7 @@
 namespace NHibernate.Test.DriverTest
 {
 	[TestFixture]
+	[Obsolete("Uses old driver")]
 	public class FirebirdClientDriverFixture
 	{
 		private string _connectionString;
diff --git a/src/NHibernate.Test/DriverTest/OracleDataClientDriverFixture.cs b/src/NHibernate.Test/DriverTest/OracleDataClientDriverFixture.cs
@@ -13,6 +13,7 @@
 namespace NHibernate.Test.DriverTest
 {
 	[TestFixture]
+	[Obsolete("Uses old driver")]
 	public class OracleDataClientDriverFixture
 	{
 		/// <summary>
@@ -151,4 +152,4 @@ private static object GetOracleParameterType(DbParameter dbParameter)
 			return typeProperty.GetValue(dbParameter);
 		}
 	}
-}
+}
diff --git a/src/NHibernate.Test/Futures/FallbackFixture.cs b/src/NHibernate.Test/Futures/FallbackFixture.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Linq;
 using NHibernate.Cfg;
 using NHibernate.Connection;
@@ -10,6 +11,7 @@
 
 namespace NHibernate.Test.Futures
 {
+	[Obsolete("Uses old driver")]
 	public class TestDriverThatDoesntSupportQueryBatching : SqlClientDriver
 	{
 		public override bool SupportsMultipleQueries => false;
@@ -23,6 +25,7 @@ public class TestDriverThatDoesntSupportQueryBatching : SqlClientDriver
 	/// but this way it's just much easier to test this
 	/// </summary>
 	[TestFixture]
+	[Obsolete("Uses old driver")]
 	public class FallbackFixture : FutureFixture
 	{
 		protected override bool AppliesTo(Dialect.Dialect dialect)
diff --git a/src/NHibernate.Test/NHSpecificTest/NH2660And2661/Test.cs b/src/NHibernate.Test/NHSpecificTest/NH2660And2661/Test.cs
@@ -7,6 +7,7 @@
 namespace NHibernate.Test.NHSpecificTest.NH2660And2661
 {
 	[TestFixture]
+	[Obsolete("Uses old driver")]
 	public class Test : BugTestCase
 	{
 		protected override void OnSetUp()
diff --git a/src/NHibernate.Test/NHSpecificTest/NH3004/Fixture.cs b/src/NHibernate.Test/NHSpecificTest/NH3004/Fixture.cs
@@ -1,10 +1,12 @@
-﻿using System.Collections;
+﻿using System;
+using System.Collections;
 using NHibernate.SqlCommand;
 using NUnit.Framework;
 
 namespace NHibernate.Test.NHSpecificTest.NH3004
 {
 	[TestFixture]
+	[Obsolete("Uses old driver")]
 	public class Fixture
 	{
 		[Test]
diff --git a/src/NHibernate.Test/NHSpecificTest/NH3004/TestSqlClientDriver.cs b/src/NHibernate.Test/NHSpecificTest/NH3004/TestSqlClientDriver.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Data.SqlClient;
 using NHibernate.AdoNet;
 using NHibernate.Dialect;
@@ -11,6 +12,7 @@ namespace NHibernate.Test.NHSpecificTest.NH3004
 	/// <summary>
 	/// A NHibernate Driver for using the SqlClient DataProvider
 	/// </summary>
+	[Obsolete("Uses old driver")]
 	public class TestSqlClientDriver : SqlClientDriver
 	{
 		bool _UseNamedPrefixInSql = true;
@@ -38,4 +40,4 @@ public override bool UseNamedPrefixInParameter
 			get { return _UseNamedPrefixInParameter; }
 		}
 	}
-}
+}
diff --git a/src/NHibernate.Test/NHSpecificTest/NH3202/Fixture.cs b/src/NHibernate.Test/NHSpecificTest/NH3202/Fixture.cs
@@ -1,14 +1,17 @@
-﻿using System.Data.Common;
+﻿using System;
+using System.Data.Common;
 using System.Text.RegularExpressions;
 using NHibernate.Cfg;
 using NHibernate.Dialect;
 using NHibernate.Driver;
 using NHibernate.Util;
 using NUnit.Framework;
+using Environment = NHibernate.Cfg.Environment;
 
 namespace NHibernate.Test.NHSpecificTest.NH3202
 {
 	[TestFixture]
+	[Obsolete("Uses old driver")]
 	public class Fixture : BugTestCase
 	{
 		protected override void Configure(Configuration configuration)
@@ -105,6 +108,7 @@ public class OffsetStartsAtOneTestDialect : MsSql2008Dialect
 	}
 
 
+	[Obsolete("Uses old driver")]
 	public class OffsetTestDriver : SqlClientDriver
 	{
 		public OffsetStartsAtOneTestDialect OffsetStartsAtOneTestDialect;
diff --git a/src/NHibernate.Test/Pagination/CustomDialectFixture.cs b/src/NHibernate.Test/Pagination/CustomDialectFixture.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Collections;
 using System.Collections.Generic;
 using NHibernate.Cfg;
@@ -10,6 +11,7 @@
 namespace NHibernate.Test.Pagination
 {
 	[TestFixture]
+	[Obsolete("Uses old driver")]
 	public class CustomDialectFixture : TestCase
 	{
 		protected override string MappingsAssembly
diff --git a/src/NHibernate.Test/Pagination/CustomMsSqlDriver.cs b/src/NHibernate.Test/Pagination/CustomMsSqlDriver.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Data.Common;
 using System.Text.RegularExpressions;
 using NHibernate.Driver;
@@ -9,6 +10,7 @@ namespace NHibernate.Test.Pagination
 	/// Class to work with CustomMsSqlDialect to allow
 	/// verification of simulated limit parameters
 	/// </summary>
+	[Obsolete("Uses old driver")]
 	public class CustomMsSqlDriver : SqlClientDriver
 	{
 		public CustomMsSqlDialect CustomMsSqlDialect;
@@ -33,4 +35,4 @@ protected override void OnBeforePrepare(DbCommand command)
 			base.OnBeforePrepare(command);
 		}
 	}
-}
+}
diff --git a/src/NHibernate.Test/TestingExtensions.cs b/src/NHibernate.Test/TestingExtensions.cs
@@ -33,7 +33,9 @@ public static bool IsOleDbDriver(this System.Type driverClass)
 		/// </summary>
 		public static bool IsSqlClientDriver(this IDriver driver)
 		{
+#pragma warning disable 618
 			if (driver is SqlClientDriver) return true;
+#pragma warning restore 618
 			return false;
 		}
 
@@ -42,26 +44,34 @@ public static bool IsSqlClientDriver(this IDriver driver)
 		/// </summary>
 		public static bool IsSqlClientDriver(this System.Type driverClass)
 		{
+#pragma warning disable 618
 			if (typeof(SqlClientDriver).IsAssignableFrom(driverClass)) return true;
+#pragma warning restore 618
 			return false;
 		}
 
 		public static bool IsSql2008ClientDriver(this IDriver driver)
 		{
+#pragma warning disable 618
 			if (driver is Sql2008ClientDriver) return true;
+#pragma warning restore 618
 			return false;
 		}
 
 		public static bool IsMySqlDataDriver(this System.Type driverClass)
 		{
+#pragma warning disable 618
 			if (typeof(MySqlDataDriver).IsAssignableFrom(driverClass)) return true;
+#pragma warning restore 618
 			return false;
 		}
 
 
 		public static bool IsFirebirdClientDriver(this IDriver driver)
 		{
+#pragma warning disable 618
 			if (driver is FirebirdClientDriver) return true;
+#pragma warning restore 618
 			return false;
 		}
 
@@ -78,9 +88,11 @@ public static void ClearPoolForFirebirdClientDriver(this IDriver driver)
 		{
 			switch (driver)
 			{
+#pragma warning disable 618
 				case FirebirdClientDriver fbDriver:
 					fbDriver.ClearPool(null);
 					break;
+#pragma warning restore 618
 			}
 		}
 
@@ -104,7 +116,9 @@ public static bool IsOracleLiteDataClientDriver(this IDriver driver)
 
 		public static bool IsOracleManagedDataClientDriver(this IDriver driver)
 		{
+#pragma warning disable 618
 			if (driver is OracleManagedDataClientDriver) return true;
+#pragma warning restore 618
 			return false;
 		}
 	}
diff --git a/src/NHibernate/Dialect/MsSql2008Dialect.cs b/src/NHibernate/Dialect/MsSql2008Dialect.cs
@@ -69,7 +69,9 @@ protected override void RegisterKeywords()
 		protected override void RegisterDefaultProperties()
 		{
 			base.RegisterDefaultProperties();
+#pragma warning disable 618
 			DefaultProperties[Environment.ConnectionDriver] = typeof(Sql2008ClientDriver).AssemblyQualifiedName;
+#pragma warning restore 618
 		}
 
 		public override string CurrentTimestampSQLFunctionName =>

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,7 @@ namespace NHibernate.Test.DriverTest`
`21`	`21`	`using System.Threading.Tasks;`
`22`	`22`	`using System.Threading;`
`23`	`23`	`[TestFixture]`
	`24`	`+ [Obsolete("Uses old driver")]`
`24`	`25`	`public class FirebirdClientDriverFixtureAsync`
`25`	`26`	`{`
`26`	`27`	`private string _connectionString;`
Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,7 @@ namespace NHibernate.Test.NHSpecificTest.NH2660And2661`
`18`	`18`	`{`
`19`	`19`	`using System.Threading.Tasks;`
`20`	`20`	`[TestFixture]`
	`21`	`+ [Obsolete("Uses old driver")]`
`21`	`22`	`public class TestAsync : BugTestCase`
`22`	`23`	`{`
`23`	`24`	`protected override void OnSetUp()`
Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@`
`8`	`8`	`//------------------------------------------------------------------------------`
`9`	`9`
`10`	`10`
	`11`	`+using System;`
`11`	`12`	`using System.Collections;`
`12`	`13`	`using System.Collections.Generic;`
`13`	`14`	`using NHibernate.Cfg;`
`@@ -21,6 +22,7 @@ namespace NHibernate.Test.Pagination`
`21`	`22`	`{`
`22`	`23`	`using System.Threading.Tasks;`
`23`	`24`	`[TestFixture]`
	`25`	`+ [Obsolete("Uses old driver")]`
`24`	`26`	`public class CustomDialectFixtureAsync : TestCase`
`25`	`27`	`{`
`26`	`28`	`protected override string MappingsAssembly`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+using System;`
`1`	`2`	`using System.Data;`
`2`	`3`	`using System.Data.SqlClient;`
`3`	`4`	`using System.IO;`
`@@ -12,13 +13,15 @@`
`12`	`13`	`using NHibernate.Linq;`
`13`	`14`	`using NHibernate.Type;`
`14`	`15`	`using NUnit.Framework;`
	`16`	`+using Environment = NHibernate.Cfg.Environment;`
`15`	`17`
`16`	`18`	`namespace NHibernate.Test.CfgTest.Loquacious`
`17`	`19`	`{`
`18`	`20`	`[TestFixture]`
`19`	`21`	`public class ConfigurationFixture`
`20`	`22`	`{`
`21`	`23`	`[Test]`
	`24`	`+ [Obsolete("Uses old driver")]`
`22`	`25`	`public void CompleteConfiguration()`
`23`	`26`	`{`
`24`	`27`	`const string connectionString = "The connection string";`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@`
`9`	`9`	`namespace NHibernate.Test.DriverTest`
`10`	`10`	`{`
`11`	`11`	`[TestFixture]`
	`12`	`+ [Obsolete("Uses old driver")]`
`12`	`13`	`public class FirebirdClientDriverFixture`
`13`	`14`	`{`
`14`	`15`	`private string _connectionString;`
Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@`
`13`	`13`	`namespace NHibernate.Test.DriverTest`
`14`	`14`	`{`
`15`	`15`	`[TestFixture]`
	`16`	`+ [Obsolete("Uses old driver")]`
`16`	`17`	`public class OracleDataClientDriverFixture`
`17`	`18`	`{`
`18`	`19`	`/// <summary>`
`@@ -151,4 +152,4 @@ private static object GetOracleParameterType(DbParameter dbParameter)`
`151`	`152`	`return typeProperty.GetValue(dbParameter);`
`152`	`153`	`}`
`153`	`154`	`}`
`154`		`-}`
	`155`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+using System;`
`1`	`2`	`using System.Linq;`
`2`	`3`	`using NHibernate.Cfg;`
`3`	`4`	`using NHibernate.Connection;`
`@@ -10,6 +11,7 @@`
`10`	`11`
`11`	`12`	`namespace NHibernate.Test.Futures`
`12`	`13`	`{`
	`14`	`+ [Obsolete("Uses old driver")]`
`13`	`15`	`public class TestDriverThatDoesntSupportQueryBatching : SqlClientDriver`
`14`	`16`	`{`
`15`	`17`	`public override bool SupportsMultipleQueries => false;`
`@@ -23,6 +25,7 @@ public class TestDriverThatDoesntSupportQueryBatching : SqlClientDriver`
`23`	`25`	`/// but this way it's just much easier to test this`
`24`	`26`	`/// </summary>`
`25`	`27`	`[TestFixture]`
	`28`	`+ [Obsolete("Uses old driver")]`
`26`	`29`	`public class FallbackFixture : FutureFixture`
`27`	`30`	`{`
`28`	`31`	`protected override bool AppliesTo(Dialect.Dialect dialect)`