nitypes: Extract typing backports into a submodule #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeryan
force-pushed
the
users/bkeryan/append-waveform
branch
from
3caa239 to
18a9000
Compare
bkeryan
force-pushed
the
users/bkeryan/refactor-typing
branch
from
d176490 to
86475a1
Compare
mikeprosserni
approved these changes
Apr 28, 2025
Collaborator
Author
|
FYI @csjall @mikeprosserni This was chained to my append waveform PR but I'm rebasing it against main so I can merge it sooner. |
bkeryan
force-pushed
the
users/bkeryan/refactor-typing
branch
from
86475a1 to
bf343e8
Compare
Contributor
bkeryan
commented
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Single-source typing backports in a single submodule.
Why should this Pull Request be merged?
Don't repeat yourself.
Avoid accidentally depending on
typing_extensionsat run time.What testing has been done?
Ran lint, mypy, and tests on Python 3.11.9