Skip to content

Commit 71a5c29

Browse files
authored
Merge pull request #167 from nicolasbock/docker_command
Add option to specify the `docker` command
2 parents 7322107 + 1b57b3b commit 71a5c29

File tree

3 files changed

+27
-1
lines changed

3 files changed

+27
-1
lines changed

ebuildtester/docker.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def execute(self, cmd):
4444
"""
4545

4646
options.log.info("%s %s" % (self.cid[:6], cmd))
47-
docker_cmd = ["docker", "exec", "--interactive"]
47+
docker_cmd = [options.options.docker_command, "exec", "--interactive"]
4848
docker_cmd += [self.cid, "/bin/bash"]
4949
docker = subprocess.Popen(docker_cmd,
5050
stdout=subprocess.PIPE,

ebuildtester/parse.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
from ebuildtester.atom import Atom
2+
import os
23
from pkg_resources import get_distribution
34
import argparse
45
import multiprocessing
@@ -111,6 +112,9 @@ def parse_commandline(args):
111112
"--docker-image",
112113
help="Specify the docker image to use (default = %(default)s)",
113114
default="gentoo/stage3")
115+
parser.add_argument(
116+
"--docker-command",
117+
help="Specify the docker command")
114118
parser.add_argument(
115119
"--pull",
116120
help="Download latest docker image",
@@ -139,4 +143,7 @@ def parse_commandline(args):
139143
else:
140144
options.update = False
141145

146+
if not options.docker_command:
147+
options.docker_command = os.getenv('DOCKER_COMMAND', default='docker')
148+
142149
return options

snap/snapcraft.yaml

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,22 @@ description: |
99
grade: stable
1010
confinement: strict
1111

12+
environment:
13+
DOCKER_COMMAND: docker-wrapper.sh
14+
15+
plugs:
16+
docker-executables:
17+
interface: content
18+
target: $SNAP/docker-snap
19+
default-provider: docker
20+
1221
apps:
1322
ebuildtester:
1423
command: bin/ebuildtester
24+
confinement:
25+
command: usr/bin/confinement.sh
26+
docker:
27+
command: usr/bin/docker-wrapper.sh
1528
plugs:
1629
- docker
1730

@@ -23,3 +36,9 @@ parts:
2336
source-tag: v0.1.30
2437
requirements:
2538
- requirements.txt
39+
docker-wrapper:
40+
plugin: dump
41+
source: .
42+
organize:
43+
confinement.sh: usr/bin/confinement.sh
44+
docker-wrapper.sh: /usr/bin/docker-wrapper.sh

0 commit comments

Comments
 (0)