Skip to content

Commit 3ac88a7

Browse files
authored
src: use string_view in WriteReport()
Since 075936b, `TriggerNodeReport()` takes `std::string_view` arguments directly. PR-URL: #60201 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
1 parent 1986ee4 commit 3ac88a7

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/node_report_module.cc

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,18 +34,18 @@ void WriteReport(const FunctionCallbackInfo<Value>& info) {
3434
Local<Value> error;
3535

3636
CHECK_EQ(info.Length(), 4);
37-
String::Utf8Value message(isolate, info[0].As<String>());
38-
String::Utf8Value trigger(isolate, info[1].As<String>());
37+
Utf8Value message(isolate, info[0].As<String>());
38+
Utf8Value trigger(isolate, info[1].As<String>());
3939

40-
if (info[2]->IsString())
41-
filename = *String::Utf8Value(isolate, info[2]);
40+
if (info[2]->IsString()) filename = Utf8Value(isolate, info[2]).ToString();
4241
if (!info[3].IsEmpty())
4342
error = info[3];
4443
else
4544
error = Local<Value>();
4645

4746
// Return value is the report filename
48-
filename = TriggerNodeReport(env, *message, *trigger, filename, error);
47+
filename = TriggerNodeReport(
48+
env, message.ToStringView(), trigger.ToStringView(), filename, error);
4949
Local<Value> ret;
5050
if (ToV8Value(env->context(), filename, env->isolate()).ToLocal(&ret)) {
5151
info.GetReturnValue().Set(ret);

0 commit comments

Comments
 (0)