lib: add innerFail as private method to Assert class

Author: miguelmarcondesf

lib/assert.js

@@ -87,6 +87,12 @@ class Assert {
     this.AssertionError = AssertionError;
   }
 
+  #innerFail(obj) {
+    if (obj.message instanceof Error) throw obj.message;
+
+    throw new AssertionError(obj);
+  }
+
   #internalMatch(string, regexp, message, fn) {
     if (!isRegExp(regexp)) {
       throw new ERR_INVALID_ARG_TYPE(
@@ -140,7 +146,7 @@ class Assert {
         err.operator = fn.name;
         throw err;
       }
-      innerFail({
+      this.#innerFail({
         actual,
         expected,
         message,
@@ -293,7 +299,7 @@ class Assert {
       }
       details += message ? `: ${message}` : '.';
       const fnType = stackStartFn === Assert.prototype.rejects ? 'rejection' : 'exception';
-      innerFail({
+      this.#innerFail({
         actual: undefined,
         expected: error,
         operator: stackStartFn.name,
@@ -321,7 +327,7 @@ class Assert {
       const details = message ? `: ${message}` : '.';
       const fnType = stackStartFn === Assert.prototype.doesNotReject ?
         'rejection' : 'exception';
-      innerFail({
+      this.#innerFail({
         actual,
         expected: error,
         operator: stackStartFn.name,
@@ -428,7 +434,7 @@ class Assert {
     }
     // eslint-disable-next-line eqeqeq
     if (actual != expected && (!NumberIsNaN(actual) || !NumberIsNaN(expected))) {
-      innerFail({
+      this.#innerFail({
         actual,
         expected,
         message,
@@ -452,7 +458,7 @@ class Assert {
     }
     // eslint-disable-next-line eqeqeq
     if (actual == expected || (NumberIsNaN(actual) && NumberIsNaN(expected))) {
-      innerFail({
+      this.#innerFail({
         actual,
         expected,
         message,
@@ -475,7 +481,7 @@ class Assert {
     }
     if (isDeepEqual === undefined) lazyLoadComparison();
     if (!isDeepEqual(actual, expected)) {
-      innerFail({
+      this.#innerFail({
         actual,
         expected,
         message,
@@ -498,7 +504,7 @@ class Assert {
     }
     if (isDeepEqual === undefined) lazyLoadComparison();
     if (isDeepEqual(actual, expected)) {
-      innerFail({
+      this.#innerFail({
         actual,
         expected,
         message,
@@ -522,7 +528,7 @@ class Assert {
     }
     if (isDeepEqual === undefined) lazyLoadComparison();
     if (!isDeepStrictEqual(actual, expected)) {
-      innerFail({
+      this.#innerFail({
         actual,
         expected,
         message,
@@ -546,7 +552,7 @@ class Assert {
     }
     if (isDeepEqual === undefined) lazyLoadComparison();
     if (isDeepStrictEqual(actual, expected)) {
-      innerFail({
+      this.#innerFail({
         actual,
         expected,
         message,
@@ -568,7 +574,7 @@ class Assert {
       throw new ERR_MISSING_ARGS('actual', 'expected');
     }
     if (!ObjectIs(actual, expected)) {
-      innerFail({
+      this.#innerFail({
         actual,
         expected,
         message,
@@ -590,7 +596,7 @@ class Assert {
       throw new ERR_MISSING_ARGS('actual', 'expected');
     }
     if (ObjectIs(actual, expected)) {
-      innerFail({
+      this.#innerFail({
         actual,
         expected,
         message,
@@ -617,7 +623,7 @@ class Assert {
     }
     if (isDeepEqual === undefined) lazyLoadComparison();
     if (!isPartialStrictEqual(actual, expected)) {
-      innerFail({
+      this.#innerFail({
         actual,
         expected,
         message,
@@ -775,13 +781,6 @@ assert.ok = ok;
 // may be undefined if not provided. All assertion methods provide
 // both the actual and expected values to the assertion error for
 // display purposes.
-
-function innerFail(obj) {
-  if (obj.message instanceof Error) throw obj.message;
-
-  throw new AssertionError(obj);
-}
-
 class Comparison {
   constructor(obj, keys, actual) {
     for (const key of keys) {

test/fixtures/errors/error_exit.snapshot

@@ -1,7 +1,7 @@
 Exiting with code=1
 node:assert:*
-  throw new AssertionError(obj);
-  ^
+    throw new AssertionError(obj);
+    ^
 
 AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: