-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
test: use assert.match for variable-based regexp tests
#60879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 2 commits into
nodejs:main
from
Renegade334:match-non-literal-regexp-tests
Nov 30, 2025
Merged
test: use assert.match for variable-based regexp tests
#60879
nodejs-github-bot
merged 2 commits into
nodejs:main
from
Renegade334:match-non-literal-regexp-tests
Nov 30, 2025
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60879 +/- ##
==========================================
+ Coverage 88.54% 88.55% +0.01%
==========================================
Files 703 703
Lines 208291 208291
Branches 40170 40172 +2
==========================================
+ Hits 184430 184458 +28
+ Misses 15865 15834 -31
- Partials 7996 7999 +3 🚀 New features to boost your workflow:
|
aduh95
reviewed
Nov 28, 2025
aduh95
reviewed
Nov 28, 2025
aduh95
approved these changes
Nov 29, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
cjihrig
approved these changes
Nov 29, 2025
Collaborator
targos
approved these changes
Nov 30, 2025
Collaborator
|
Landed in 6274eb7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These cases can't be linted without type parsing, but we may as well change them alongside the others.
Refs: #60832