Skip to content

fix: improve clipboard success animation in code blocks (#7946) #7950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2025

Conversation

Everkers
Copy link
Contributor

@Everkers Everkers commented Jul 4, 2025

Description

Improves the clipboard success animation for code blocks.
The previous animation was abrupt and barely visible, which felt out of place compared to the otherwise modern UI. This PR introduces a smoother transition, to improve visibility and user experience.

Validation

Tested locally by clicking the copy button on multiple code blocks.
The new animation is clearly visible, smoother, and feels more consistent with the design language of the site.

Related Issues

Fixes #7946

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • [] I've covered new added functionality with unit tests if necessary.
Screen.Recording.2025-07-04.at.3.09.44.PM.mov

@Everkers Everkers requested a review from a team as a code owner July 4, 2025 14:11
Copy link

vercel bot commented Jul 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 15, 2025 3:01pm

@avivkeller
Copy link
Member

@Everkers Can you take a look at the reviews, and rebase? Thank you!

@Everkers
Copy link
Contributor Author

@Everkers Can you take a look at the reviews, and rebase? Thank you!

Hello @avivkeller, apologies for the late reply. I've updated the PR to only increase the duration of the toast to avoid the UI flash. Unfortunately, achieving the animation with Radix requires those CSS keyframes, which I agree complicates what should have been a simple change.

@avivkeller
Copy link
Member

Thank you! I'm not opposed to the other change, per-say, but IMO it requires separate discussion, since, it's vastly more complex.

Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.12%. Comparing base (b035290) to head (f2cebf6).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7950      +/-   ##
==========================================
+ Coverage   73.10%   73.12%   +0.02%     
==========================================
  Files          95       95              
  Lines        8355     8354       -1     
  Branches      219      218       -1     
==========================================
+ Hits         6108     6109       +1     
+ Misses       2246     2244       -2     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller avivkeller added this pull request to the merge queue Jul 15, 2025
Merged via the queue into nodejs:main with commit 53352b3 Jul 15, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The clipboard success message is abrupt and vanishes too fast
5 participants