Merge pull request #434 from notion-dotnet/413-fix-date-mention-creation-and-deserialization

413 fix date mention creation and deserialization

Author: KoditkarVedant

Src/Notion.Client/Api/Databases/RequestParams/DatabasesCreateParameters/MentionInput.cs

@@ -17,6 +17,6 @@ public class MentionInput
         public ObjectId Database { get; set; }
 
         [JsonProperty("date")]
-        public DatePropertyValue Date { get; set; }
+        public Date Date { get; set; }
     }
 }

Src/Notion.Client/Models/Database/RichText/RichTextMention.cs

@@ -25,7 +25,7 @@ public class Mention
         public ObjectId Database { get; set; }
 
         [JsonProperty("date")]
-        public DatePropertyValue Date { get; set; }
+        public Date Date { get; set; }
     }
 
     public class ObjectId

Test/Notion.IntegrationTests/DatabasesClientTests.cs

@@ -1,4 +1,5 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
 using System.Linq;
 using System.Threading.Tasks;
 using FluentAssertions;
@@ -140,4 +141,48 @@ private async Task<Database> CreateDatabaseWithAPageAsync(string databaseName)
 
         return createdDatabase;
     }
+
+    [Fact]
+    public async Task Verify_mention_date_property_parsed_properly()
+    {
+        // Arrange
+        var createDbRequest = new DatabasesCreateParameters
+        {
+            Title = new List<RichTextBaseInput>
+            {
+                new RichTextTextInput
+                {
+                    Text = new Text
+                    {
+                        Content = "Test DB",
+                        Link = null
+                    }
+                },
+                new RichTextMentionInput
+                {
+                    Mention = new MentionInput
+                    {
+                        Date = new Date
+                        {
+                            Start = DateTime.UtcNow,
+                            End = DateTime.UtcNow.AddDays(1)
+                        }
+                    }
+                }
+            },
+            Properties = new Dictionary<string, IPropertySchema>
+            {
+                { "Name", new TitlePropertySchema { Title = new Dictionary<string, object>() } },
+            },
+            Parent = new ParentPageInput { PageId = _page.Id }
+        };
+
+        // Act
+        var createdDatabase = await Client.Databases.CreateAsync(createDbRequest);
+
+        // Assert
+        var mention = createdDatabase.Title.OfType<RichTextMention>().First().Mention;
+        mention.Date.Start.Should().NotBeNull();
+        mention.Date.End.Should().NotBeNull();
+    }
 }

Test/Notion.IntegrationTests/PageClientTests.cs

@@ -400,23 +400,16 @@ public async Task Verify_date_property_is_parsed_correctly_in_mention_object()
                         {
                             Mention = new Mention()
                             {
-                                Page = new ObjectId()
+                                Date = new Date()
                                 {
-                                    Id = _page.Id,
-                                },
-                                Date = new DatePropertyValue()
-                                {
-                                    Date = new Date()
-                                    {
-                                        Start = DateTime.UtcNow
-                                    }
+                                    Start = DateTime.UtcNow
                                 }
                             }
                         }
                     }
                 })
             .Build();
-        
+
         var page = await Client.Pages.CreateAsync(pageRequest);
 
         page.Should().NotBeNull();
@@ -434,9 +427,8 @@ public async Task Verify_date_property_is_parsed_correctly_in_mention_object()
                 PropertyId = pageProperty.Id
             });
 
-        titleProperty.Results.First()
-            .As<TitlePropertyItem>()
-            .Title.As<RichTextMention>()
-            .Mention.Date.Date.Should().NotBeNull();
+        var mention = titleProperty.Results.First().As<TitlePropertyItem>().Title.As<RichTextMention>().Mention;
+        mention.Date.Start.Should().NotBeNull();
+        mention.Date.End.Should().BeNull();
     }
 }