Skip to content

Conversation

@dualc
Copy link

@dualc dualc commented Aug 6, 2025

What does this PR do?

undecoded is byte, which can't concatenate with str type, so fix some type mismatch err in cat function
fix issue #820

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we pls add some tests?

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.13%. Comparing base (cb2eb37) to head (b979d54).
⚠️ Report is 22 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #821      +/-   ##
==========================================
- Coverage   91.54%   91.13%   -0.42%     
==========================================
  Files          17       17              
  Lines        1621     1635      +14     
==========================================
+ Hits         1484     1490       +6     
- Misses        137      145       +8     
Files with missing lines Coverage Δ
papermill/s3.py 78.17% <100.00%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb6b602...b979d54. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dualc
Copy link
Author

dualc commented Nov 21, 2025

Could we pls add some tests?

ok,I have added test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants