-
Notifications
You must be signed in to change notification settings - Fork 445
fix:s3 handler ,cat function decode exception #821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Borda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we pls add some tests?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #821 +/- ##
==========================================
- Coverage 91.54% 91.13% -0.42%
==========================================
Files 17 17
Lines 1621 1635 +14
==========================================
+ Hits 1484 1490 +6
- Misses 137 145 +8
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ok,I have added test |
What does this PR do?
undecoded is byte, which can't concatenate with str type, so fix some type mismatch err in cat function
fix issue #820