Fix failing tests in CI #826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Member
|
Alright, CI is churning away. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #826 +/- ##
==========================================
- Coverage 91.54% 91.29% -0.25%
==========================================
Files 17 17
Lines 1621 1632 +11
==========================================
+ Hits 1484 1490 +6
- Misses 137 142 +5 🚀 New features to boost your workflow:
|
winniehell
commented
Nov 11, 2025
winniehell
commented
Nov 12, 2025
| google_compute_engine # Need this because boto has issues with dynamic package loading during tests if other google components are there | ||
| ipython>=5.0 | ||
| # newer versions of ipython have different imports and require refactoring | ||
| ipython>=5.0,<9.0.0 |
Contributor
Author
There was a problem hiding this comment.
the other test failure was caused by an import error
| assert Path.cwd() != old_cwd | ||
| assert Path.cwd() == Path(temp_dir) | ||
| assert Path.cwd().resolve() != old_cwd.resolve() | ||
| assert Path.cwd().resolve() == Path(temp_dir).resolve() |
Contributor
Author
There was a problem hiding this comment.
this failed on macOS
rgbkrk
approved these changes
Nov 12, 2025
Member
|
Since you've gotten this much further on unblocking other PRs, I'd say it's ok for us to merge this. Then you can tackle the other issues in new PRs. |
winniehell
changed the title
Member
|
Not sure what the pending runs for the others are waiting on. Codecov going down for this fix seems irrelevant. Let's get this out there to help other PRs out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.