Skip to content

Commit df620ac

Browse files
committed
fix(tooling): nullable options
1 parent d9f3727 commit df620ac

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

source/Nuke.Tooling/ToolTasks.Run.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ namespace Nuke.Common.Tooling;
1212

1313
partial class ToolTasks
1414
{
15-
protected virtual IReadOnlyCollection<Output> Run(ToolOptions options)
15+
protected virtual partial IReadOnlyCollection<Output> Run(ToolOptions options)
1616
{
17-
var secrets = options.GetSecrets().ToList();
17+
var secrets = options?.GetSecrets().ToList() ?? [];
1818
string Filter(string text) => secrets.Aggregate(text, (str, s) => str.Replace(s, "[REDACTED]"));
1919

2020
options = PreProcess(options);
@@ -35,7 +35,7 @@ protected virtual IReadOnlyCollection<Output> Run(ToolOptions options)
3535
return process.Output;
3636
}
3737

38-
protected virtual (TResult Result, IReadOnlyCollection<Output> Output) Run<TResult>(ToolOptions options)
38+
protected virtual partial (TResult Result, IReadOnlyCollection<Output> Output) Run<TResult>(ToolOptions options)
3939
{
4040
var output = Run(options);
4141
try

source/Nuke.Tooling/ToolTasks.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ public abstract partial class ToolTasks
1717
protected internal virtual partial Action<OutputType, string> GetLogger(ToolOptions options = null);
1818

1919
protected virtual partial string GetToolPath(ToolOptions options = null);
20+
protected virtual partial IReadOnlyCollection<Output> Run(ToolOptions options = null);
21+
protected virtual partial (TResult Result, IReadOnlyCollection<Output> Output) Run<TResult>(ToolOptions options = null);
2022
protected virtual partial Func<ToolOptions, IProcess, object> GetExitHandler(ToolOptions options = null);
2123

2224
protected virtual ToolOptions PreProcess(ToolOptions options) => options;

0 commit comments

Comments
 (0)