Skip to content

fix(PageCard): reverse prop not applying for < lg #5545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: v4
Choose a base branch
from
+5 −5
Open

fix(PageCard): reverse prop not applying for < lg #5545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ec7d23
fix responsive reverse order on page card
mikenewbon Nov 27, 2025
bed123c
Merge branch 'v4' into reverse-card
mikenewbon Nov 27, 2025
4830c66
update test snapshots
mikenewbon Nov 27, 2025
83a3e03
fix again after merge
mikenewbon Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/theme/page-card.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export default (options: Required<NuxtOptions['ui']>) => ({
},
reverse: {
true: {
wrapper: 'lg:order-last'
wrapper: 'order-last'
}
},
variant: {
Expand Down
4 changes: 2 additions & 2 deletions test/components/__snapshots__/PageCard-vue.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ exports[`PageCard > renders with orientation horizontal reverse correctly 1`] =
"<div data-orientation="horizontal" data-slot="root" class="relative flex rounded-lg bg-default ring ring-default">
<!--v-if-->
<div data-slot="container" class="relative flex flex-col flex-1 lg:grid gap-x-8 gap-y-4 p-4 sm:p-6 lg:grid-cols-2 lg:items-center">
<div data-slot="wrapper" class="flex flex-col flex-1 items-start lg:order-last">
<div data-slot="wrapper" class="flex flex-col flex-1 items-start order-last">
<!--v-if-->
<div data-slot="leading" class="inline-flex items-center mb-2.5"><svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" aria-hidden="true" role="img" width="1em" height="1em" viewBox="0 0 16 16" data-slot="leadingIcon" class="size-5 shrink-0 text-primary"></svg></div>
<div data-slot="body" class="flex-1">
Expand Down Expand Up @@ -386,7 +386,7 @@ exports[`PageCard > renders with orientation vertical reverse correctly 1`] = `
"<div data-orientation="vertical" data-slot="root" class="relative flex rounded-lg bg-default ring ring-default">
<!--v-if-->
<div data-slot="container" class="relative flex flex-col flex-1 lg:grid gap-x-8 gap-y-4 p-4 sm:p-6">
<div data-slot="wrapper" class="flex flex-col flex-1 items-start lg:order-last">
<div data-slot="wrapper" class="flex flex-col flex-1 items-start order-last">
<!--v-if-->
<div data-slot="leading" class="inline-flex items-center mb-2.5"><svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" aria-hidden="true" role="img" width="1em" height="1em" viewBox="0 0 16 16" data-slot="leadingIcon" class="size-5 shrink-0 text-primary"></svg></div>
<div data-slot="body" class="flex-1">
Expand Down
4 changes: 2 additions & 2 deletions test/components/__snapshots__/PageCard.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ exports[`PageCard > renders with orientation horizontal reverse correctly 1`] =
"<div data-orientation="horizontal" data-slot="root" class="relative flex rounded-lg bg-default ring ring-default">
<!--v-if-->
<div data-slot="container" class="relative flex flex-col flex-1 lg:grid gap-x-8 gap-y-4 p-4 sm:p-6 lg:grid-cols-2 lg:items-center">
<div data-slot="wrapper" class="flex flex-col flex-1 items-start lg:order-last">
<div data-slot="wrapper" class="flex flex-col flex-1 items-start order-last">
<!--v-if-->
<div data-slot="leading" class="inline-flex items-center mb-2.5"><span class="iconify i-lucide:house size-5 shrink-0 text-primary" aria-hidden="true" data-slot="leadingIcon"></span></div>
<div data-slot="body" class="flex-1">
Expand Down Expand Up @@ -386,7 +386,7 @@ exports[`PageCard > renders with orientation vertical reverse correctly 1`] = `
"<div data-orientation="vertical" data-slot="root" class="relative flex rounded-lg bg-default ring ring-default">
<!--v-if-->
<div data-slot="container" class="relative flex flex-col flex-1 lg:grid gap-x-8 gap-y-4 p-4 sm:p-6">
<div data-slot="wrapper" class="flex flex-col flex-1 items-start lg:order-last">
<div data-slot="wrapper" class="flex flex-col flex-1 items-start order-last">
<!--v-if-->
<div data-slot="leading" class="inline-flex items-center mb-2.5"><span class="iconify i-lucide:house size-5 shrink-0 text-primary" aria-hidden="true" data-slot="leadingIcon"></span></div>
<div data-slot="body" class="flex-1">
Expand Down
Loading