Skip to content

Commit 8bc1d14

Browse files
committed
fixup! Fix gyps for common.gypi removal in chromium repo
1 parent 9d80931 commit 8bc1d14

File tree

1 file changed

+92
-5
lines changed

1 file changed

+92
-5
lines changed

common.gypi

Lines changed: 92 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
'v8_enable_i18n_support%': 1,
3434
#'icu_use_data_file_flag%': 1,
3535
'openssl_fips': '',
36+
'win_fastlink': 0,
3637

3738
# Don't use ICU data file (icudtl.dat) from V8, we use our own.
3839
'icu_use_data_file_flag%': 0,
@@ -81,7 +82,81 @@
8182
],
8283
},
8384
'configurations': {
84-
'Debug': {
85+
'Common_Base': {
86+
'abstract': 1,
87+
'msvs_settings':{
88+
'VCCLCompilerTool': {
89+
'AdditionalOptions': [
90+
'/bigobj',
91+
# Tell the compiler to crash on failures. This is undocumented
92+
# and unsupported but very handy.
93+
'/d2FastFail',
94+
],
95+
},
96+
'VCLinkerTool': {
97+
# Add the default import libs.
98+
'AdditionalDependencies': [
99+
'kernel32.lib',
100+
'gdi32.lib',
101+
'winspool.lib',
102+
'comdlg32.lib',
103+
'advapi32.lib',
104+
'shell32.lib',
105+
'ole32.lib',
106+
'oleaut32.lib',
107+
'user32.lib',
108+
'uuid.lib',
109+
'odbc32.lib',
110+
'odbccp32.lib',
111+
'delayimp.lib',
112+
'credui.lib',
113+
'dbghelp.lib',
114+
'shlwapi.lib',
115+
'winmm.lib',
116+
],
117+
'AdditionalOptions': [
118+
# Suggested by Microsoft Devrel to avoid
119+
# LINK : fatal error LNK1248: image size (80000000) exceeds maximum allowable size (80000000)
120+
# which started happening more regularly after VS2013 Update 4.
121+
# Needs to be a bit lower for VS2015, or else errors out.
122+
'/maxilksize:0x7ff00000',
123+
# Tell the linker to crash on failures.
124+
'/fastfail',
125+
],
126+
},
127+
},
128+
'conditions': [
129+
['OS=="win" and win_fastlink==1 and MSVS_VERSION != "2013"', {
130+
'msvs_settings': {
131+
'VCLinkerTool': {
132+
# /PROFILE is incompatible with /debug:fastlink
133+
'Profile': 'false',
134+
'AdditionalOptions': [
135+
# Tell VS 2015+ to create a PDB that references debug
136+
# information in .obj and .lib files instead of copying
137+
# it all.
138+
'/DEBUG:FASTLINK',
139+
],
140+
},
141+
},
142+
}],
143+
['OS=="win" and MSVS_VERSION == "2015"', {
144+
'msvs_settings': {
145+
'VCCLCompilerTool': {
146+
'AdditionalOptions': [
147+
# Work around crbug.com/526851, bug in VS 2015 RTM compiler.
148+
'/Zc:sizedDealloc-',
149+
# Disable thread-safe statics to avoid overhead and because
150+
# they are disabled on other platforms. See crbug.com/587210
151+
# and -fno-threadsafe-statics.
152+
'/Zc:threadSafeInit-',
153+
],
154+
},
155+
},
156+
}],
157+
],
158+
},
159+
'Debug_Base': {
85160
'variables': {
86161
'v8_enable_handle_zapping': 1,
87162
},
@@ -116,7 +191,7 @@
116191
'GCC_OPTIMIZATION_LEVEL': '0', # stop gyp from defaulting to -Os
117192
},
118193
},
119-
'Release': {
194+
'Release_Base': {
120195
'variables': {
121196
'v8_enable_handle_zapping': 0,
122197
},
@@ -164,7 +239,19 @@
164239
'LinkIncremental': 1, # disable incremental linking
165240
},
166241
},
167-
}
242+
},
243+
'Debug': {
244+
'inherit_from': ['Common_Base', 'Debug_Base'],
245+
},
246+
'Release': {
247+
'inherit_from': ['Common_Base', 'Release_Base'],
248+
},
249+
'conditions': [
250+
[ 'OS=="win"', {
251+
'Debug_x64': { 'inherit_from': ['Debug'] },
252+
'Release_x64': { 'inherit_from': ['Release'], },
253+
}],
254+
],
168255
},
169256
# Forcibly disable -Werror. We support a wide range of compilers, it's
170257
# simply not feasible to squelch all warnings, never mind that the
@@ -210,7 +297,7 @@
210297
'SuppressStartupBanner': 'true',
211298
},
212299
},
213-
'msvs_disabled_warnings': [4351, 4355, 4800],
300+
'msvs_disabled_warnings': [4351, 4355, 4800, 4595],
214301
'conditions': [
215302
['asan == 1 and OS != "mac"', {
216303
'cflags+': [
@@ -251,7 +338,7 @@
251338
'_CRT_NONSTDC_NO_DEPRECATE',
252339
# Make sure the STL doesn't try to use exceptions
253340
'_HAS_EXCEPTIONS=0',
254-
'BUILDING_V8_SHARED=1',
341+
#'BUILDING_V8_SHARED=1',
255342
'BUILDING_UV_SHARED=1',
256343
],
257344
}],

0 commit comments

Comments
 (0)