Skip to content

Commit 10e37b1

Browse files
committed
Merge branch 'proudust-fix-prop-types-err'
2 parents aee0b25 + 478b6e4 commit 10e37b1

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

src/index.test.tsx

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ describe('Testing CSVReader props:', () => {
6767
test('has cssLabelClass prop set', () => {
6868
const cssLabelClass = 'custom-csv-label'
6969
const { getByText } = render(csvReader)
70-
const labelNode = getByText("CSV input label text");
70+
const labelNode = getByText('CSV input label text')
7171

7272
expect([...labelNode.classList]).toEqual([cssLabelClass])
7373
})
@@ -102,3 +102,13 @@ describe('Testing CSVReader props:', () => {
102102
expect(inputNode.getAttribute('disabled')).toBeDefined()
103103
})
104104
})
105+
106+
test('prop-types error when give RefObject to inputRef', async () => {
107+
console.error = jest.fn()
108+
const inputRef: React.RefObject<HTMLInputElement> = { current: null }
109+
React.createElement(CSVReader, {
110+
inputRef,
111+
onFileLoaded: (data, fileInfo) => console.dir(data, fileInfo),
112+
})
113+
expect(console.error).toHaveBeenCalledTimes(0)
114+
})

src/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ CSVReader.propTypes = {
105105
inputId: PropTypes.string,
106106
inputName: PropTypes.string,
107107
inputStyle: PropTypes.object,
108-
inputRef: PropTypes.func,
108+
inputRef: PropTypes.oneOfType([PropTypes.func, PropTypes.exact({ current: PropTypes.instanceOf(HTMLInputElement) })]),
109109
label: PropTypes.oneOfType([PropTypes.string, PropTypes.element]),
110110
onError: PropTypes.func,
111111
onFileLoaded: PropTypes.func.isRequired,

0 commit comments

Comments
 (0)