Skip to content

Commit 0560144

Browse files
authored
fix: redis-ha subchart deployment / service name in template helpers (#338)
* fix: redis-ha subchart deployment / service name in template helpers * add changelog entry Signed-off-by: Jan Larwig <[email protected]> --------- Signed-off-by: Jan Larwig <[email protected]>
1 parent 9b08b04 commit 0560144

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

helm/oauth2-proxy/Chart.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: oauth2-proxy
2-
version: 8.0.0
2+
version: 8.0.1
33
apiVersion: v2
44
appVersion: 7.11.0
55
home: https://oauth2-proxy.github.io/oauth2-proxy/
@@ -31,8 +31,8 @@ maintainers:
3131
kubeVersion: ">=1.16.0-0"
3232
annotations:
3333
artifacthub.io/changes: |
34-
- kind: changed
35-
description: Replace Redis chart by bitnami with dandydeveloper/redis-ha chart
34+
- kind: fixed
35+
description: Fixes how the fullname for the deployment / service of the newly introduced redis-ha subchart is generated
3636
links:
3737
- name: Github PR
38-
url: https://github.com/oauth2-proxy/manifests/pull/335
38+
url: https://github.com/oauth2-proxy/manifests/pull/338

helm/oauth2-proxy/ci/redis-standalone-values.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ sessionStorage:
77
# provision an instance of the redis-ha sub-chart
88
redis:
99
enabled: true
10-
fullnameOverride: oauth2-proxy-redis
1110

1211
redisPassword: "foo"
1312

helm/oauth2-proxy/templates/_helpers.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ Redis subcharts fullname
9494
*/}}
9595
{{- define "oauth2-proxy.redis.fullname" -}}
9696
{{- if .Values.redis.enabled -}}
97-
{{- include "redis-ha.fullname" (dict "Chart" (dict "Name" "redis-ha") "Release" .Release "Values" .Values.redis) -}}
97+
{{- include "redis-ha.fullname" (dict "Chart" (dict "Name" "redis") "Release" .Release "Values" .Values.redis) -}}
9898
{{- else -}}
9999
{{ fail "attempting to use redis subcharts fullname, even though the subchart is not enabled. This will lead to misconfiguration" }}
100100
{{- end -}}

0 commit comments

Comments
 (0)