[create-pull-request] automated change (#48)

Co-authored-by: oblomov-dev <[email protected]>

Author: github-actions[bot]

src/zoblomov_cl_util.clas.abap

@@ -653,7 +653,7 @@ CLASS zoblomov_cl_util IMPLEMENTATION.
   METHOD filter_get_range_by_token.
 
     DATA(lv_length) = strlen( value ) - 1.
-    CASE value(1).
+    CASE VALUE(1).
 
       WHEN `=`.
         result = VALUE #( sign   = `I`
@@ -1524,7 +1524,8 @@ CLASS zoblomov_cl_util IMPLEMENTATION.
       ENDIF.
 
       INSERT INITIAL LINE INTO tab ASSIGNING <row_out> INDEX lv_lines.
-      <row_out> = CORRESPONDING #( <row_in> ).
+      CLEAR: <row_out>.
+      MOVE-CORRESPONDING <row_in> TO <row_out>.
 
     ENDLOOP.
 

src/zoblomov_cl_util.clas.testclasses.abap

@@ -45,7 +45,7 @@ CLASS ltcl_test_app IMPLEMENTATION.
 ENDCLASS.
 
 
-CLASS ltcl_unit_test_abap_api DEFINITION FINAL
+CLASS ltcl_unit_test_open_abap DEFINITION FINAL
   FOR TESTING RISK LEVEL HARMLESS DURATION SHORT.
 
   PRIVATE SECTION.
@@ -121,7 +121,7 @@ CLASS ltcl_unit_test DEFINITION FINAL
 ENDCLASS.
 
 
-CLASS ltcl_unit_test_abap_api IMPLEMENTATION.
+CLASS ltcl_unit_test_open_abap IMPLEMENTATION.
   METHOD test_assign.
 
     DATA(lo_app) = NEW ltcl_test_app( ).

src/zoblomov_cl_util_abap.clas.abap

@@ -231,7 +231,7 @@ CLASS zoblomov_cl_util_abap DEFINITION
         transport         TYPE sxco_transport,
         task              TYPE sxco_transport,
         selkz             TYPE abap_bool,
-        locl              type abap_bool,
+        locl              TYPE abap_bool,
       END OF ty_s_transport.
 
     TYPES ty_t_data TYPE STANDARD TABLE OF ty_s_transport WITH EMPTY KEY.
@@ -651,7 +651,6 @@ CLASS zoblomov_cl_util_abap IMPLEMENTATION.
     TRY.
 
         lv_class  = to_upper( iv_classname ).
-
         lv_method = to_upper( iv_methodname ).
 
         xco_cp_abap = 'XCO_CP_ABAP'.
@@ -797,12 +796,12 @@ CLASS zoblomov_cl_util_abap IMPLEMENTATION.
         lv_fm = `SEO_INTERFACE_IMPLEM_GET_ALL`.
         CALL FUNCTION lv_fm
           EXPORTING
-            intkey       = ls_key
+            intkey        = ls_key
           IMPORTING
-            impkeys      = lt_impl
+            impkeys       = lt_impl
           EXCEPTIONS
-            not_existing = 1
-            OTHERS       = 2.
+            error_message = 1
+            OTHERS        = 2.
         IF sy-subrc <> 0.
           RETURN.
         ENDIF.
@@ -821,9 +820,15 @@ CLASS zoblomov_cl_util_abap IMPLEMENTATION.
           lv_fm = `SEO_CLASS_READ`.
           CALL FUNCTION lv_fm
             EXPORTING
-              clskey = ls_clskey
+              clskey        = ls_clskey
             IMPORTING
-              class  = <class>.
+              class         = <class>
+            EXCEPTIONS
+              error_message = 1
+              OTHERS        = 2.
+          IF sy-subrc <> 0.
+            RAISE EXCEPTION TYPE zoblomov_cx_util_error.
+          ENDIF.
 
           ASSIGN
             COMPONENT 'DESCRIPT'
@@ -944,7 +949,8 @@ CLASS zoblomov_cl_util_abap IMPLEMENTATION.
               RECEIVING
                 rs_long_field_label = result-long.
 
-          CATCH cx_root.
+          CATCH cx_root INTO DATA(x).
+            DATA(error) = x->get_text( ).
         ENDTRY.
     ENDTRY.
 
@@ -1190,7 +1196,8 @@ CLASS zoblomov_cl_util_abap IMPLEMENTATION.
 
         ENDLOOP.
 
-      CATCH cx_root.
+      CATCH cx_root INTO DATA(x).
+        DATA(error) = x->get_text( ).
     ENDTRY.
 
   ENDMETHOD.
@@ -1243,7 +1250,8 @@ CLASS zoblomov_cl_util_abap IMPLEMENTATION.
               APPEND <field> TO names.
             ENDLOOP.
         ENDTRY.
-      CATCH cx_root.
+      CATCH cx_root INTO DATA(x).
+        DATA(error) = x->get_text( ).
     ENDTRY.
 
 
@@ -1587,7 +1595,8 @@ CLASS zoblomov_cl_util_abap IMPLEMENTATION.
 
     CREATE DATA lr_shlp TYPE (lv_type).
     ASSIGN lr_shlp->* TO <shlp>.
-    <shlp> = CORRESPONDING #( ms_shlp ).
+    CLEAR: <shlp>.
+    MOVE-CORRESPONDING ms_shlp TO <shlp>.
 
     lv_fm = 'F4IF_SELECT_VALUES'.
     CALL FUNCTION lv_fm
@@ -1663,8 +1672,8 @@ CLASS zoblomov_cl_util_abap IMPLEMENTATION.
             TRY.
                 " Sting table will crash if value length <> outputlen
                 <line_content> = result_line+result_desc-offset.
-              CATCH cx_root.
-                " rest of the fields are empty.
+              CATCH cx_root INTO DATA(x).
+                DATA(error) = x->get_text( ).
             ENDTRY.
         ENDTRY.
 
@@ -1853,8 +1862,8 @@ CLASS zoblomov_cl_util_abap IMPLEMENTATION.
         ASSIGN t_e071k->* TO <t_e071k>.
         ASSIGN s_e071k->* TO <s_e071k>.
 
-      CATCH cx_root.
-
+      CATCH cx_root INTO DATA(x).
+        DATA(error) = x->get_text( ).
     ENDTRY.
 
     DATA(dfies) = zoblomov_cl_util=>rtti_get_t_dfies_by_table_name( iv_tabname ).
@@ -1953,8 +1962,8 @@ CLASS zoblomov_cl_util_abap IMPLEMENTATION.
         ASSIGN t_e071->* TO <t_e071>.
         ASSIGN s_e071->* TO <s_e071>.
 
-      CATCH cx_root.
-
+      CATCH cx_root INTO DATA(x).
+        DATA(error) = x->get_text( ).
     ENDTRY.
 
     ASSIGN COMPONENT 'TRKORR' OF STRUCTURE <s_e071> TO <value>.
@@ -2043,7 +2052,8 @@ CLASS zoblomov_cl_util_abap IMPLEMENTATION.
         IF sy-subrc <> 0.
           RETURN.
         ENDIF.
-      CATCH cx_root.
+      CATCH cx_root INTO DATA(x).
+        DATA(error) = x->get_text( ).
     ENDTRY.
 
     LOOP AT <table> INTO <line>.
@@ -2159,7 +2169,8 @@ CLASS zoblomov_cl_util_abap IMPLEMENTATION.
             RETURN.
           ENDIF.
 
-        CATCH cx_root.
+        CATCH cx_root INTO DATA(x).
+          DATA(error) = x->get_text( ).
       ENDTRY.
 
       LOOP AT <table> INTO <line>.
@@ -2205,7 +2216,8 @@ CLASS zoblomov_cl_util_abap IMPLEMENTATION.
 
         TRY.
             <row> = sy-mandt.
-          CATCH cx_root.
+          CATCH cx_root INTO DATA(x).
+            DATA(error) = x->get_text( ).
         ENDTRY.
 
       ENDIF.
@@ -2231,15 +2243,17 @@ CLASS zoblomov_cl_util_abap IMPLEMENTATION.
 
         CALL FUNCTION conex
           EXPORTING
-            input  = val
+            input         = val
           IMPORTING
-            output = result
+            output        = result
           EXCEPTIONS
-            OTHERS = 99.
+            error_message = 1
+            OTHERS        = 2.
         IF sy-subrc <> 0.
-
+          RAISE EXCEPTION TYPE zoblomov_cx_util_error.
         ENDIF.
 
+
       ENDIF.
 
     ENDIF.

src/zoblomov_cl_util_db.clas.abap

@@ -151,6 +151,4 @@ CLASS zoblomov_cl_util_db IMPLEMENTATION.
 
   ENDMETHOD.
 
-
-
 ENDCLASS.

src/zoblomov_cl_util_msg.clas.abap

@@ -1,23 +1,26 @@
 CLASS zoblomov_cl_util_msg DEFINITION PUBLIC
   FINAL CREATE PUBLIC.
   PUBLIC SECTION.
+
     CLASS-METHODS msg_map
       IMPORTING
         name          TYPE clike
         val           TYPE data
         is_msg        TYPE zoblomov_cl_util=>ty_s_msg
       RETURNING
         VALUE(result) TYPE zoblomov_cl_util=>ty_s_msg.
+
     CLASS-METHODS msg_get
       IMPORTING
         val           TYPE any
       RETURNING
         VALUE(result) TYPE zoblomov_cl_util=>ty_t_msg.
+
 ENDCLASS.
 
 CLASS zoblomov_cl_util_msg IMPLEMENTATION.
-  METHOD msg_get.
 
+  METHOD msg_get.
 
     DATA(lv_kind) = zoblomov_cl_util=>rtti_get_type_kind( val ).
     CASE lv_kind.
@@ -53,7 +56,7 @@ CLASS zoblomov_cl_util_msg IMPLEMENTATION.
 
         ENDLOOP.
         IF ls_result-text IS INITIAL AND ls_result-id IS NOT INITIAL.
-        ls_result-id = TO_UPPER( ls_result-id ).
+          ls_result-id = to_upper( ls_result-id ).
           MESSAGE ID ls_result-id TYPE 'I' NUMBER ls_result-no
                   WITH ls_result-v1 ls_result-v2 ls_result-v3 ls_result-v4
                   INTO ls_result-text.
@@ -131,8 +134,8 @@ CLASS zoblomov_cl_util_msg IMPLEMENTATION.
 
 
   ENDMETHOD.
-  METHOD msg_map.
 
+  METHOD msg_map.
 
     result = is_msg.
     CASE name.
@@ -156,6 +159,5 @@ CLASS zoblomov_cl_util_msg IMPLEMENTATION.
         result-timestampl = val.
     ENDCASE.
 
-
   ENDMETHOD.
 ENDCLASS.

src/zoblomov_cl_util_range.clas.abap

@@ -1,55 +1,61 @@
 CLASS zoblomov_cl_util_range DEFINITION PUBLIC
   FINAL CREATE PUBLIC.
   PUBLIC SECTION.
-    CONSTANTS: BEGIN OF signs,
-                 including TYPE string VALUE 'I',
-                 excluding TYPE string VALUE 'E',
-               END OF signs.
-    CONSTANTS: BEGIN OF options,
-                 equal                TYPE string VALUE 'EQ',
-                 not_equal            TYPE string VALUE 'NE',
-                 between              TYPE string VALUE 'BT',
-                 not_between          TYPE string VALUE 'NB',
-                 contains_pattern     TYPE string VALUE 'CP',
-                 not_contains_pattern TYPE string VALUE 'NP',
-                 greater_than         TYPE string VALUE 'GT',
-                 greater_equal        TYPE string VALUE 'GE',
-                 less_equal           TYPE string VALUE 'LE',
-                 less_than            TYPE string VALUE 'LT',
-               END OF options.
+
+    CONSTANTS:
+      BEGIN OF signs,
+        including TYPE string VALUE 'I',
+        excluding TYPE string VALUE 'E',
+      END OF signs.
+
+    CONSTANTS:
+      BEGIN OF options,
+        equal                TYPE string VALUE 'EQ',
+        not_equal            TYPE string VALUE 'NE',
+        between              TYPE string VALUE 'BT',
+        not_between          TYPE string VALUE 'NB',
+        contains_pattern     TYPE string VALUE 'CP',
+        not_contains_pattern TYPE string VALUE 'NP',
+        greater_than         TYPE string VALUE 'GT',
+        greater_equal        TYPE string VALUE 'GE',
+        less_equal           TYPE string VALUE 'LE',
+        less_than            TYPE string VALUE 'LT',
+      END OF options.
+
     METHODS constructor
       IMPORTING
         iv_fieldname TYPE clike
         ir_range     TYPE REF TO data.
+
     METHODS get_sql
       RETURNING
         VALUE(result) TYPE string.
+
   PROTECTED SECTION.
+
     DATA mv_fieldname TYPE string.
     DATA mr_range     TYPE REF TO data.
+
     CLASS-METHODS quote
       IMPORTING
         val        TYPE clike
       RETURNING
         VALUE(out) TYPE string.
+
 ENDCLASS.
 
 CLASS zoblomov_cl_util_range IMPLEMENTATION.
-  METHOD constructor.
 
+  METHOD constructor.
 
     mr_range = ir_range.
     mv_fieldname = |{ to_upper( iv_fieldname ) }|.
 
-
-    mr_range = ir_range.
-    mv_fieldname = |{ to_upper( iv_fieldname ) }|.
   ENDMETHOD.
-  METHOD get_sql.
 
+  METHOD get_sql.
 
     FIELD-SYMBOLS <lt_range> TYPE STANDARD TABLE.
-
     ASSIGN me->mr_range->* TO <lt_range>.
 
     IF xsdbool( <lt_range> IS INITIAL ) = abap_true.
@@ -102,16 +108,15 @@ CLASS zoblomov_cl_util_range IMPLEMENTATION.
 
     result = |{ result } )|.
 
-
   ENDMETHOD.
-  METHOD quote.
 
+  METHOD quote.
 
     out = |'{ replace( val  = val
                        sub  = `'`
                        with = `''`
                        occ  = 0 ) }'|.
 
-
   ENDMETHOD.
+
 ENDCLASS.