Skip to content

Commit 5ff1ef0

Browse files
committed
wip: drop prompt and parameter overrides and implement prompt proxying
Signed-off-by: Nick Hale <[email protected]>
1 parent a3e6c99 commit 5ff1ef0

File tree

9 files changed

+110
-475
lines changed

9 files changed

+110
-475
lines changed

apiclient/types/mcpserver.go

Lines changed: 8 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,10 @@ type CompositeCatalogConfig struct {
6262

6363
// CatalogComponentServer represents a component server in a composite server catalog entry.
6464
type CatalogComponentServer struct {
65-
CatalogEntryID string `json:"catalogEntryID"`
66-
MCPServerID string `json:"mcpServerID,omitempty"`
67-
Manifest MCPServerCatalogEntryManifest `json:"manifest"`
68-
ToolOverrides []ToolOverride `json:"toolOverrides,omitempty"`
69-
PromptOverrides []PromptOverride `json:"promptOverrides,omitempty"`
65+
CatalogEntryID string `json:"catalogEntryID"`
66+
MCPServerID string `json:"mcpServerID,omitempty"`
67+
Manifest MCPServerCatalogEntryManifest `json:"manifest"`
68+
ToolOverrides []ToolOverride `json:"toolOverrides,omitempty"`
7069
}
7170

7271
type CompositeRuntimeConfig struct {
@@ -77,10 +76,9 @@ type ComponentServer struct {
7776
// CatalogEntryID is used when the component server is a single-user or remote server.
7877
CatalogEntryID string `json:"catalogEntryID"`
7978
// MCPServerID is used when the component server is a multi-user server.
80-
MCPServerID string `json:"mcpServerID,omitempty"`
81-
Manifest MCPServerManifest `json:"manifest"`
82-
ToolOverrides []ToolOverride `json:"toolOverrides,omitempty"`
83-
PromptOverrides []PromptOverride `json:"promptOverrides,omitempty"`
79+
MCPServerID string `json:"mcpServerID,omitempty"`
80+
Manifest MCPServerManifest `json:"manifest"`
81+
ToolOverrides []ToolOverride `json:"toolOverrides,omitempty"`
8482
}
8583

8684
type MCPServerCatalogEntry struct {
@@ -117,19 +115,6 @@ type MCPServerCatalogEntryManifest struct {
117115
Env []MCPEnv `json:"env,omitempty"`
118116
}
119117

120-
// TODO(njhale): Prompt and tool overrides are effectively the same types with slightly different field names.
121-
// Consolidate them into a single set of types.
122-
123-
// ParameterOverride is used to override the name and description of a parameter.
124-
type ParameterOverride struct {
125-
// Name is the original parameter name as defined by the component server
126-
Name string `json:"name"`
127-
// OverrideName is the parameter name exposed by the composite server
128-
OverrideName string `json:"overrideName"`
129-
// Optional override for parameter description
130-
OverrideDescription string `json:"overrideDescription,omitempty"`
131-
}
132-
133118
// ToolOverride defines how a single component tool is exposed by the composite server
134119
type ToolOverride struct {
135120
// Name is the original tool name as returned by the component server
@@ -140,25 +125,6 @@ type ToolOverride struct {
140125
OverrideDescription string `json:"overrideDescription,omitempty"`
141126
// Whether to include this tool (default true)
142127
Enabled bool `json:"enabled,omitempty"`
143-
// Optional parameter name/description overrides
144-
ParameterOverrides []ParameterOverride `json:"parameterOverrides,omitempty"`
145-
}
146-
147-
// PromptArgumentOverride is used to override the name and description of a prompt argument.
148-
type PromptArgumentOverride ParameterOverride
149-
150-
// PromptOverride is used to override the name and description of a prompt.
151-
type PromptOverride struct {
152-
// Name is the original prompt name as returned by the component server
153-
Name string `json:"name"`
154-
// OverrideName is the prompt name exposed by the composite server
155-
OverrideName string `json:"overrideName"`
156-
// Optional overrides for display
157-
OverrideDescription string `json:"overrideDescription,omitempty"`
158-
// Whether to include this prompt (default true)
159-
Enabled bool `json:"enabled,omitempty"`
160-
// Optional argument name/description overrides
161-
ArgumentOverrides []PromptArgumentOverride `json:"argumentOverrides,omitempty"`
162128
}
163129

164130
type MCPHeader struct {
@@ -442,8 +408,7 @@ func MapCatalogEntryToServer(catalogEntry MCPServerCatalogEntryManifest, userURL
442408
CatalogEntryID: catalogComponent.CatalogEntryID,
443409
Manifest: componentServerManifest,
444410
ToolOverrides: catalogComponent.ToolOverrides,
445-
PromptOverrides: catalogComponent.PromptOverrides,
446-
}
411+
}
447412
}
448413

449414
serverManifest.CompositeConfig = &CompositeRuntimeConfig{

apiclient/types/zz_generated.deepcopy.go

Lines changed: 2 additions & 75 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/api/handlers/mcp.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1112,8 +1112,7 @@ func serverManifestFromCatalogEntryManifest(isAdmin bool, entry types.MCPServerC
11121112
CatalogEntryID: c.CatalogEntryID,
11131113
Manifest: mapped,
11141114
ToolOverrides: c.ToolOverrides,
1115-
PromptOverrides: c.PromptOverrides,
1116-
})
1115+
})
11171116
}
11181117

11191118
if isAdmin {

0 commit comments

Comments
 (0)