Skip to content

Improve Statefulset Label Missing logging #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve Statefulset Label Missing logging #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
581d83e
improve statefulset logging
alecrajeev Feb 15, 2024
fd88827
fix ci
alecrajeev Feb 15, 2024
5ea9ebf
fix ci
alecrajeev Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions examples/dashboards/receive-controller.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
{
"expr": "sum by (namespace, job) (rate(thanos_receive_controller_reconcile_attempts_total{namespace=\"$namespace\", job=\"$job\"}[$interval]))",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "rate",
"legendLink": null
}
Expand Down Expand Up @@ -122,7 +121,6 @@
{
"expr": "sum by (namespace, job, type) (rate(thanos_receive_controller_reconcile_errors_total{namespace=\"$namespace\", job=\"$job\"}[$interval]))",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{type}}",
"legendLink": null
}
Expand Down Expand Up @@ -209,7 +207,6 @@
{
"expr": "sum by (namespace, job) (rate(thanos_receive_controller_configmap_change_attempts_total{namespace=\"$namespace\", job=\"$job\"}[$interval]))",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "rate",
"legendLink": null
}
Expand Down Expand Up @@ -284,7 +281,6 @@
{
"expr": "sum by (namespace, job, type) (rate(thanos_receive_controller_configmap_change_errors_total{namespace=\"$namespace\", job=\"$job\"}[$interval]))",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{type}}",
"legendLink": null
}
Expand Down Expand Up @@ -371,7 +367,6 @@
{
"expr": "sum by (namespace, job) (rate(thanos_receive_hashrings_file_changes_total{job=~\"thanos-receive-default.*\"}[$interval]))",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "all",
"legendLink": null
}
Expand Down Expand Up @@ -536,14 +531,12 @@
{
"expr": "avg by (namespace, job, name) (thanos_receive_controller_hashring_nodes{namespace=\"$namespace\", job=\"$job\"})",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "receive controller {{name}}",
"legendLink": null
},
{
"expr": "avg by (namespace, job, name) (thanos_receive_hashring_nodes{job=~\"thanos-receive-default.*\"})",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "receive {{name}}",
"legendLink": null
}
Expand Down Expand Up @@ -618,14 +611,12 @@
{
"expr": "avg by (namespace, job, name) (thanos_receive_controller_hashring_tenants{namespace=\"$namespace\", job=\"$job\"})",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "receive controller {{name}}",
"legendLink": null
},
{
"expr": "avg by (namespace, job, name) (thanos_receive_hashring_tenants{job=~\"thanos-receive-default.*\"})",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "receive {{name}}",
"legendLink": null
}
Expand Down Expand Up @@ -716,7 +707,6 @@
"expr": "time() - max by (namespace, job) (thanos_receive_controller_configmap_last_reload_success_timestamp_seconds{namespace=\"$namespace\", job=\"$job\"})",
"format": "time_series",
"instant": true,
"intervalFactor": 2,
"refId": "A"
}
],
Expand Down Expand Up @@ -794,7 +784,6 @@
"expr": "time() - max by (namespace, job) (thanos_receive_config_last_reload_success_timestamp_seconds{namespace=\"$namespace\", job=\"$job\"})",
"format": "time_series",
"instant": true,
"intervalFactor": 2,
"refId": "A"
}
],
Expand Down Expand Up @@ -857,7 +846,7 @@
"value": "default"
},
"hide": 0,
"label": "Data Source",
"label": "Data source",
"name": "datasource",
"options": [ ],
"query": "prometheus",
Expand Down
8 changes: 8 additions & 0 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,6 +551,8 @@ func (c *controller) sync(ctx context.Context) {

statefulsets := make(map[string]*appsv1.StatefulSet)

var matchingStatefulSet bool

for _, obj := range c.ssetInf.GetStore().List() {
sts, ok := obj.(*appsv1.StatefulSet)
if !ok {
Expand All @@ -560,6 +562,8 @@ func (c *controller) sync(ctx context.Context) {
hashring, ok := sts.Labels[hashringLabelKey]
if !ok {
continue
} else {
matchingStatefulSet = true
}

// If there's an increase in replicas we poll for the new replicas to be ready
Expand All @@ -584,6 +588,10 @@ func (c *controller) sync(ctx context.Context) {
time.Sleep(c.options.scaleTimeout) // Give some time for all replicas before they receive hundreds req/s
}

if !matchingStatefulSet {
level.Warn(c.logger).Log("msg", "could not find a statefulset with the label key "+hashringLabelKey)
}

c.populate(ctx, hashrings, statefulsets)

err = c.saveHashring(ctx, hashrings, cm)
Expand Down