Add ubuntu-family distribution support to lmdb.1.0 #28986
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spotted this in #28931
Linux distributions derived from Ubuntu are consider
os-family="ubuntu". One such example is Mint, withAccording to https://github.com/ocaml/opam-repository/wiki/Depexts-os-distribution---os-family-values
this should also be the case for Ubuntu itself.
I no longer think that is the case, and that the wiki table entry for Ubuntu is wrong.
Looking at an Ubuntu CI run of #28931, e.g.,
https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/8f00c13a54683097cc781d46df0c18b7f635d303/variant/distributions,ubuntu-24.04-ocaml-5.4,lmdb.1.0
I see
os-familyisn't printed byopam config reportliblmdb-devdepext being installed, meaning it must have matched the line["liblmdb-dev"] {os-family = "debian"}from before this PR (no other lines name exactly that package).In conclusion: