[FIX] answers to comments

Author: thjo-odoo

addons/html_builder/static/src/builder.js

@@ -45,6 +45,7 @@ export class Builder extends Component {
         toggleFullscreen: { type: Function, optional: true },
         toggleCodeView: { type: Function, optional: true },
         getExternalScrollableAncestor: { type: Function, optional: true },
+        fullscreenLogo: { type: String, optional: true },
     };
     static defaultProps = {
         onEditorLoad: () => {},

addons/html_builder/static/src/builder.xml

@@ -13,7 +13,10 @@
                 <button t-if="props.toggleCodeView" t-on-click="props.toggleCodeView"
                     class="o-hb-btn btn d-flex align-items-center o_codeview_btn" title="Code View" accesskey="d"><i class="fa fa-code"/></button>
                 <button t-if="props.toggleFullscreen" t-on-click="props.toggleFullscreen"
-                    class="o-hb-btn btn d-flex align-items-center" title="Fullscreen" accesskey="f">FS</button>
+                    class="o-hb-btn btn d-flex align-items-center" title="Fullscreen" accesskey="f">
+                    <span t-if="props.fullscreenLogo" t-attf-class="fa #{props.fullscreenLogo}"/>
+                    <t t-else="">FS</t>
+                </button>
                 <button t-if="props.closeEditor" type="button"  t-on-click="discard" class="o-hb-btn btn" data-action="cancel" title="Tip: Esc to preview" accesskey="j">Discard</button>
                 <button t-if="props.closeEditor" type="button" t-on-click="save" class="o-hb-btn btn btn-success px-3" data-action="save" accesskey="s">Save</button>
             </div>

addons/html_builder/static/src/plugins/border_configurator_option.xml

@@ -17,7 +17,7 @@
     </BuilderRow>
 
     <!-- TODO: handle the dependency with border_width_opt bg_color_opt-->
-    <BuilderRow t-if="props.withRoundCorner" label.translate="Round Corners">
+    <BuilderRow t-if="props.withRoundCorner and state.hasBorder" label.translate="Round Corners">
         <BuilderNumberInput action="props.action" actionParam="{ mainParam: 'border-radius', extraClass: props.withBSClass and 'rounded' }" unit="'px'" min="0" composable="true"/>
     </BuilderRow>
 </t>

addons/mass_mailing_egg/static/src/builder/fontfamily_picker.xml

@@ -1,6 +1,6 @@
 <templates>
     <t t-name="mass_mailing_egg.FontFamilyPicker">
-        <BuilderSelect action="this.props.action" actionParam="this.props.actionParam">
+        <BuilderSelect className="'ps-2'" action="this.props.action" actionParam="this.props.actionParam">
             <t t-foreach="Object.entries(this.FONT_FAMILIES)" t-as="fontFamily" t-key="fontFamily[0]">
                 <BuilderSelectItem t-out="fontFamily[0]" actionValue="fontFamily[1]"/>
             </t>

addons/mass_mailing_egg/static/src/builder/mass_mailing_builder.xml

@@ -1,7 +1,7 @@
 <templates>
 
 <t t-name="mass_mailing_egg.MassMailingBuilder">
-    <Builder t-props="builderProps"/>
+    <Builder t-props="builderProps" fullscreenLogo="'fa-expand'"/>
 </t>
 
 </templates>

addons/mass_mailing_egg/static/src/builder/options/image_tool_option.xml

@@ -7,7 +7,7 @@
                 <BuilderSelectItem classAction="'float-end'">Right</BuilderSelectItem>
             </BuilderSelect>
         </BuilderRow>
-        <t t-call="mass_mailing.BorderOptionNoRoundedCornersDependency"/>
+        <t t-call="mass_mailing.BorderOption"/>
         <t t-call="mass_mailing.HorizontalPaddingOption"/>
         <t t-call="mass_mailing.VerticalPaddingOption"/>
     </t>

addons/mass_mailing_egg/static/src/builder/plugins/alert_option_plugin.js

@@ -13,7 +13,7 @@ class AlertOptionPlugin extends Plugin {
             }),
             withSequence(after(WIDTH), {
                 selector: ".s_mail_alert .s_alert",
-                template: "mass_mailing.BorderOptionNoRoundedCornersDependency"
+                template: "mass_mailing.BorderOption",
             }),
         ],
         patch_builder_options: [

addons/mass_mailing_egg/static/src/builder/plugins/border_option_plugin.js

@@ -8,7 +8,7 @@ export class BorderOptionPlugin extends Plugin {
     resources = {
         builder_options: [
             withSequence(before(WIDTH), {
-                template: "mass_mailing.BorderOptionNoRoundedCornersDependency",
+                template: "mass_mailing.BorderOption",
                 selector:
                     ".s_three_columns .row > div, .s_comparisons .row > div, .s_mail_block_event .row > div",
                 applyTo: ".card",

addons/mass_mailing_egg/static/src/fields/html_field/mass_mailing_html_field.js

@@ -175,6 +175,7 @@ export class MassMailingHtmlField extends HtmlMailField {
         delete config.Plugins;
         return {
             ...config,
+            allowMediaDialogVideo: false, // videos aren't allowed in mails
             withBuilder: true,
             // TODO EGGMAIL?: allow the builder to show the theme selection again
             // Applying a new Theme from the builder should CREATE AN EDITOR STEP