[IMP] cf: add top10 conditional formatting operator #7559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
hokolomopo
commented
Nov 28, 2025
Comment on lines
+116
to
+123
| const evaluator = criterionEvaluatorRegistry.get(cf.rule.operator); | ||
| const criterion = { ...cf.rule, type: cf.rule.operator }; | ||
| const ranges = cf.ranges.map((xc) => this.getters.getRangeFromSheetXC(sheetId, xc)); | ||
| const preComputedCriterion = evaluator.preComputeCriterion?.( | ||
| criterion, | ||
| ranges, | ||
| this.getters | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
Not a huge fan, but top10 do a sort to get the top X values, and we really don't wanna sort the range once for every cell of the range, it will explode on big ranges. Even if we use a better algorithm than sorting the range to find the top 10, the best case is still O(n²) ...
Contributor
Author
There was a problem hiding this comment.
The name preComputeCriterion/preComputedCriterion also kinda sucks, I'm open to propositions
fdamhaut
approved these changes
Dec 2, 2025
Contributor
fdamhaut
left a comment
fdamhaut
left a comment
There was a problem hiding this comment.
Small functional nitpick, I don't have a better idea for the name of the preComputed Value
hokolomopo
force-pushed
the
master-additional-cfs-adrm
branch
from
d41f50a to
7e1c6a3
Compare
This commits adds the "top10" conditional formatting operator, which highlights the top or bottom N values in a selected range. Task: 5367065
hokolomopo
force-pushed
the
master-additional-cfs-adrm
branch
from
7e1c6a3 to
efdc84e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commits adds the "top10" conditional formatting operator, which highlights the top or bottom N values in a selected range.
Task: 5367065
review checklist