[ADD] estate: Add data validation rules for prices and offer acceptance

- Prevents negative or zero amounts for property and offer prices
- Ensures property types and tags must be unique
- Blocks accepting offers lower than 90% of the expected price

Author: pusu-odoo

estate/__manifest__.py

@@ -1,17 +1,17 @@
 {
     "name": "Real Estate",
     "description": "",
-    "depends": ['base'],
+    "depends": ["base"],
     "sequence": 1,
-    "data" : [
-        'security/ir.model.access.csv',
-        'views/estate_property_views.xml',
-        'views/estate_property_type_views.xml',
-        'views/estate_property_tag_views.xml',
-        'views/estate_property_offer_views.xml',
-        'views/estate_menus.xml',
+    "data": [
+        "security/ir.model.access.csv",
+        "views/estate_property_views.xml",
+        "views/estate_property_type_views.xml",
+        "views/estate_property_tag_views.xml",
+        "views/estate_property_offer_views.xml",
+        "views/estate_menus.xml",
     ],
     "license": "LGPL-3",
     "application": True,
-    "installable": True
-}
+    "installable": True,
+}

estate/models/estate_property.py

@@ -1,38 +1,43 @@
 from odoo import models, fields, api
+from odoo.exceptions import ValidationError
 from odoo.exceptions import UserError
+from odoo.tools import float_is_zero, float_compare
 from datetime import timedelta
 
+
 class EstateProperty(models.Model):
-    _name = 'estate.property'
-    _description = 'Estate Property'
+    _name = "estate.property"
+    _description = "Estate Property"
 
-    name = fields.Char(string="Name",required=True)
+    name = fields.Char(string="Name", required=True)
     description = fields.Text(string="Description")
     active = fields.Boolean(
         string="Active",
-        default=True, 
-        help="Mark as active if you want the property to be listed.",)
+        default=True,
+        help="Mark as active if you want the property to be listed.",
+    )
     postcode = fields.Char(string="Postcode")
     property_type_id = fields.Many2one("estate.property.type", string="Property Type")
     date_availability = fields.Date(
-        string='Available From',
-        default= fields.Date.today() + timedelta(days=90), 
-        copy=False)
-    expected_price = fields.Float(string="Expected Price",required=True)
-    selling_price = fields.Float(string="Selling Price" ,readonly=True ,copy=False)
-    bedrooms = fields.Integer(string="Bedrooms",default=2)
+        string="Available From",
+        default=fields.Date.today() + timedelta(days=90),
+        copy=False,
+    )
+    expected_price = fields.Float(string="Expected Price", required=True)
+    selling_price = fields.Float(string="Selling Price", readonly=True, copy=False)
+    bedrooms = fields.Integer(string="Bedrooms", default=2)
     living_area = fields.Integer(string="Living Area (sqm)")
     facades = fields.Integer(string="Facades")
     garage = fields.Boolean(string="Garage")
     garden = fields.Boolean(string="Garden")
     garden_area = fields.Integer(string="Garden Area (sqm)")
     garden_orientation = fields.Selection(
-        string='Garden Orientation',
-        selection = [
-            ('north', 'North'), 
-            ('south', 'South'), 
-            ('east', 'East'), 
-            ('west', 'West')
+        string="Garden Orientation",
+        selection=[
+            ("north", "North"),
+            ("south", "South"),
+            ("east", "East"),
+            ("west", "West"),
         ],
     )
     total_area = fields.Integer(
@@ -55,29 +60,32 @@ class EstateProperty(models.Model):
     salesman_id = fields.Many2one(
         "res.users", string="Salesman", default=lambda self: self.env.user
     )
-    buyer_id = fields.Many2one("res.partner", string="Buyer", copy = False) 
+    buyer_id = fields.Many2one("res.partner", string="Buyer", copy=False)
 
     tag_ids = fields.Many2many(
-        'estate.property.tag', 
-        string='Tags', 
-        help='Properties associated with this tag.'
-    ) 
+        "estate.property.tag",
+        string="Tags",
+        help="Properties associated with this tag.",
+    )
 
     offer_ids = fields.One2many(
-        'estate.property.offer',
-        'property_id',
-        string='Offers',
-        help='Offers made on this property.')
-    
+        "estate.property.offer",
+        "property_id",
+        string="Offers",
+        help="Offers made on this property.",
+    )
+
     best_price = fields.Float(
-        string = "Best Offer",
-        compute = "_compute_best_price",
+        string="Best Offer",
+        compute="_compute_best_price",
     )
-    
-    @api.depends('living_area', 'garden_area', 'garden')
+
+    @api.depends("living_area", "garden_area", "garden")
     def _compute_total_area(self):
         for property in self:
-            property.total_area = property.living_area + (property.garden_area if property.garden else 0)
+            property.total_area = property.living_area + (
+                property.garden_area if property.garden else 0
+            )
 
     @api.depends("offer_ids.price")
     def _compute_best_price(self):
@@ -89,27 +97,55 @@ def _onchange_garden(self):
         for property in self:
             if property.garden:
                 property.garden_area = 10
-                property.garden_orientation = 'north'
+                property.garden_orientation = "north"
             else:
                 property.garden_area = 0
                 property.garden_orientation = False
 
     def action_set_sold(self):
         for property in self:
             if property.selling_price > 0.0 and property.state != "cancelled":
-                property.state = 'sold'
+                property.state = "sold"
             elif property.state == "cancelled":
                 raise UserError("A cancelled property cannot be sold.")
             elif property.state == "new" or property.state == "offer received":
-                raise UserError("This property must have an accepted offer before it can be sold.")
+                raise UserError(
+                    "This property must have an accepted offer before it can be sold."
+                )
             elif property.state == "sold":
                 raise UserError("This property is already sold.")
-            
+
     def action_set_cancelled(self):
         for property in self:
             if property.state != "cancelled" and property.state != "sold":
-                property.state = 'cancelled'
+                property.state = "cancelled"
             elif property.state == "cancelled":
                 raise UserError("This property is already cancelled.")
             elif property.state == "sold":
-                raise UserError("A sold property cannot be cancelled.")
+                raise UserError("A sold property cannot be cancelled.")
+
+    _sql_constraints = [
+        (
+            "check_expected_price",
+            "CHECK(expected_price > 0)",
+            "The expected price must be greater than 0.",
+        ),
+    ]
+
+    @api.constrains("selling_price", "expected_price")
+    def _check_selling_price(self):
+        for property in self:
+            if float_is_zero(property.selling_price, precision_rounding=2):
+                continue
+
+            if (
+                float_compare(
+                    property.selling_price,
+                    property.expected_price * 0.9,
+                    precision_rounding=2,
+                )
+                < 0
+            ):
+                raise ValidationError(
+                    "The selling price cannot be lower than 90'%' of the expected price!"
+                )

estate/models/estate_property_offer.py

@@ -2,47 +2,55 @@
 from odoo.exceptions import UserError
 from datetime import timedelta
 
+
 class EstatePropertyOffer(models.Model):
-    _name = 'estate.property.offer'
-    _description = 'Estate Property Offer'
+    _name = "estate.property.offer"
+    _description = "Estate Property Offer"
 
     price = fields.Float(string="Price")
     status = fields.Selection(
         string="Status",
         selection=[
-            ('accepted', 'Accepted'),
-            ('refused', 'Refused'),
-        ]
+            ("accepted", "Accepted"),
+            ("refused", "Refused"),
+        ],
     )
     validity = fields.Integer(
-        string = "Validity (days)",
+        string="Validity (days)",
         default=7,
-        help="Validity of the offer in days, after that it will be refused automatically."
+        help="Validity of the offer in days, after that it will be refused automatically.",
     )
     date_deadline = fields.Date(
-        string = "Deadline",
+        string="Deadline",
         compute="_compute_date_deadline",
         inverse="_inverse_date_deadline",
         store=True,
     )
-    partner_id = fields.Many2one("res.partner", string="Partner" , required=True)
-    property_id = fields.Many2one("estate.property",string="Property", required=True)
+    partner_id = fields.Many2one("res.partner", string="Partner", required=True)
+    property_id = fields.Many2one("estate.property", string="Property", required=True)
 
-    @api.depends('validity')
+    @api.depends("validity")
     def _compute_date_deadline(self):
         for offer in self:
-            base_date = fields.Date.to_date(offer.create_date) if offer.create_date else fields.Date.context_today(offer)
+            base_date = (
+                fields.Date.to_date(offer.create_date)
+                if offer.create_date
+                else fields.Date.context_today(offer)
+            )
             offer.date_deadline = base_date + timedelta(days=offer.validity or 0)
 
     def _inverse_date_deadline(self):
         for offer in self:
             if offer.date_deadline:
-                base_date = fields.Date.to_date(offer.create_date) if offer.create_date else fields.Date.context_today(offer)
+                base_date = (
+                    fields.Date.to_date(offer.create_date)
+                    if offer.create_date
+                    else fields.Date.context_today(offer)
+                )
                 offer.validity = (offer.date_deadline - base_date).days
             else:
                 offer.validity = 0
 
-
     # @api.onchange("date_deadline")
     # def _onchange_date_deadline(self):
     #     for offer in self:
@@ -55,23 +63,27 @@ def _inverse_date_deadline(self):
     def action_set_accepted(self):
         for offer in self:
             if offer.property_id.selling_price == 0.0:
-                offer.status = 'accepted'
-                offer.property_id.state = 'offer accepted'
+                offer.status = "accepted"
+                offer.property_id.state = "offer accepted"
                 offer.property_id.selling_price = offer.price
                 offer.property_id.buyer_id = offer.partner_id
 
                 other_offers = offer.property_id.offer_ids - offer
 
-                other_offers.write({'status': 'refused'})
+                other_offers.write({"status": "refused"})
             else:
                 raise UserError("One offer is already accepted for this property.")
-            
+
     def action_set_refused(self):
         for offer in self:
-            if offer.status == 'accepted':
-                offer.status = 'refused'
-                offer.property_id.state = 'offer received'
+            if offer.status == "accepted":
+                offer.status = "refused"
+                offer.property_id.state = "offer received"
                 offer.property_id.buyer_id = False
                 offer.property_id.selling_price = 0.0
             else:
-                raise UserError("This offer is not accepted, so it cannot be refused.")
+                raise UserError("This offer is not accepted, so it cannot be refused.")
+
+    _sql_constraints = [
+        ("check_price", "CHECK(price > 0)", "The price must be greater than 0."),
+    ]

estate/models/estate_property_tag.py

@@ -1,9 +1,13 @@
 from odoo import models, fields
 
+
 class EstatePropertyTag(models.Model):
-    _name = 'estate.property.tag'
-    _description = 'Estate Property Tag'
+    _name = "estate.property.tag"
+    _description = "Estate Property Tag"
 
     name = fields.Char(string="Tag Name", required=True)
     description = fields.Text(string="Description")
-    
+
+    _sql_constraints = [
+        ("unique_name", "UNIQUE(name)", "A tag with same name is already exists."),
+    ]

estate/models/estate_property_type.py

@@ -1,7 +1,12 @@
 from odoo import models, fields
 
+
 class EstatePropertyType(models.Model):
-    _name = 'estate.property.type'
-    _description = 'Estate Property Type'
+    _name = "estate.property.type"
+    _description = "Estate Property Type"
 
     name = fields.Char(required=True)
+
+    _sql_constraints = [
+        ("unique_name", "UNIQUE(name)", "A type with same name is already exists."),
+    ]