[FIX] util/fields: handle o2m when removing relation field

`relation_field_id` is an ON DELETE CASCADE FK. This triggers the
removal of entries in `ir_model_fields` when we remove a field
referenced by an o2m field. This action leaves many (metadata) leftovers
for manual fields. To avoid potential issues we call `remove_field` on
such fields. That way the full cleanup (domains, contexts, filters,
etc.) happens.

We also now warn about compute implementation of manual fields if we
detect that the implementation may refer to a field being removed from
the depends.

closes #321

Signed-off-by: Christophe Simonis (chs) <[email protected]>

Author: aj-fuentes

src/util/fields.py

@@ -278,17 +278,27 @@ def adapter(leaf, is_or, negated):
     # remove this field from dependencies of other fields
     if column_exists(cr, "ir_model_fields", "depends"):
         cr.execute(
-            "SELECT id,model,depends FROM ir_model_fields WHERE state='manual' AND depends ~ %s",
+            "SELECT id,model,depends,COALESCE(compute,''),name FROM ir_model_fields WHERE state='manual' AND depends ~ %s",
             [r"\m{}\M".format(fieldname)],
         )
-        for id, from_model, deps in cr.fetchall():
+        for id, from_model, deps, compute_code, dep_field_name in cr.fetchall():
             parts = []
             for part in deps.split(","):
                 path = part.strip().split(".")
                 if not any(
                     path[i] == fieldname and _valid_path_to(cr, path[:i], from_model, model) for i in range(len(path))
                 ):
                     parts.append(part)
+                elif fieldname in compute_code:
+                    _logger.warning(
+                        "Field %s.%s depends on removed field %s.%s and its compute code references it, "
+                        "this may lead to errors.",
+                        from_model,
+                        dep_field_name,
+                        model,
+                        fieldname,
+                    )
+
             if len(parts) != len(deps.split(",")):
                 cr.execute("UPDATE ir_model_fields SET depends=%s WHERE id=%s", [", ".join(parts) or None, id])
 
@@ -319,20 +329,6 @@ def adapter(leaf, is_or, negated):
             )
             ENVIRON.setdefault("_gone_m2m", {})[m2m_rel] = "%s:%s" % (model, fieldname)
 
-    # remove the ir.model.fields entry (and its xmlid)
-    cr.execute(
-        """
-            WITH del AS (
-                DELETE FROM ir_model_fields WHERE model=%s AND name=%s RETURNING id
-            )
-            DELETE FROM ir_model_data
-                  USING del
-                  WHERE model = 'ir.model.fields'
-                    AND res_id = del.id
-        """,
-        [model, fieldname],
-    )
-
     # cleanup translations
     if table_exists(cr, "ir_translation"):
         cr.execute(
@@ -393,6 +389,40 @@ def adapter(leaf, is_or, negated):
     if drop_column and stored:
         remove_column(cr, table, fieldname, cascade=cascade)
 
+    # relation_field_id is a FK with ON DELETE CASCADE
+    if column_exists(cr, "ir_model_fields", "relation_field_id"):
+        cr.execute(
+            """
+            SELECT d.model,
+                   d.name
+              FROM ir_model_fields d
+              JOIN ir_model_fields f
+                ON d.relation_field_id = f.id
+             WHERE f.model = %s
+               AND f.name = %s
+               AND d.ttype = 'one2many'
+               AND d.state = 'manual'
+            """,
+            [model, fieldname],
+        )
+        for rel_model, rel_field in cr.fetchall():
+            _logger.info("Cascade removing one2many field %s.%s", rel_model, rel_field)
+            remove_field(cr, rel_model, rel_field)
+
+    # remove the ir.model.fields entry (and its xmlid)
+    cr.execute(
+        """
+            WITH del AS (
+                DELETE FROM ir_model_fields WHERE model=%s AND name=%s RETURNING id
+            )
+            DELETE FROM ir_model_data
+                  USING del
+                  WHERE model = 'ir.model.fields'
+                    AND res_id = del.id
+        """,
+        [model, fieldname],
+    )
+
     # remove field on inherits
     for inh in for_each_inherit(cr, model, skip_inherit):
         remove_field(