Remove unused mcaLister field

Since we now use managedClusterAddonIndexer for efficient lookup,
the mcaLister field is no longer needed. This cleanup reduces
memory usage and simplifies the controller structure.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Signed-off-by: zhujian <[email protected]>

Author: zhujian7

pkg/addon/controllers/addontemplate/controller.go

@@ -52,7 +52,6 @@ type addonTemplateController struct {
 	workClient                 workv1client.Interface
 	kubeClient                 kubernetes.Interface
 	cmaLister                  addonlisterv1alpha1.ClusterManagementAddOnLister
-	mcaLister                  addonlisterv1alpha1.ManagedClusterAddOnLister
 	managedClusterAddonIndexer cache.Indexer
 	addonInformers             addoninformers.SharedInformerFactory
 	clusterInformers           clusterv1informers.SharedInformerFactory
@@ -83,7 +82,6 @@ func NewAddonTemplateController(
 		addonClient:                addonClient,
 		workClient:                 workClient,
 		cmaLister:                  addonInformers.Addon().V1alpha1().ClusterManagementAddOns().Lister(),
-		mcaLister:                  addonInformers.Addon().V1alpha1().ManagedClusterAddOns().Lister(),
 		managedClusterAddonIndexer: addonInformers.Addon().V1alpha1().ManagedClusterAddOns().Informer().GetIndexer(),
 		addonManagers:              make(map[string]context.CancelFunc),
 		addonInformers:             addonInformers,

pkg/addon/controllers/addontemplate/controller_test.go

@@ -375,7 +375,6 @@ func TestStopUnusedManagers(t *testing.T) {
 				addonClient:                fakeAddonClient,
 				workClient:                 fakeWorkClient,
 				cmaLister:                  addonInformers.Addon().V1alpha1().ClusterManagementAddOns().Lister(),
-				mcaLister:                  addonInformers.Addon().V1alpha1().ManagedClusterAddOns().Lister(),
 				managedClusterAddonIndexer: addonInformers.Addon().V1alpha1().ManagedClusterAddOns().Informer().GetIndexer(),
 				addonManagers:              existingManagers,
 				addonInformers:             addonInformers,