Replace inefficient list-and-filter with indexed lookup in runController

Use managedClusterAddonIndexer.ByIndex() instead of listing all ManagedClusterAddOns
and filtering by name. This provides O(1) indexed lookup instead of O(n) linear scan.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Signed-off-by: zhujian <[email protected]>

Author: zhujian7

pkg/addon/controllers/addontemplate/controller.go

@@ -8,7 +8,6 @@ import (
 	"github.com/openshift/library-go/pkg/operator/events"
 	"k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"k8s.io/apimachinery/pkg/labels"
 	utilruntime "k8s.io/apimachinery/pkg/util/runtime"
 	"k8s.io/client-go/dynamic/dynamicinformer"
 	kubeinformers "k8s.io/client-go/informers"
@@ -131,9 +130,10 @@ func (c *addonTemplateController) stopUnusedManagers(
 
 	stopFunc, ok := c.addonManagers[addOnName]
 	if ok {
+		logger.Info("Start to stop the manager for addon", "addonName", addOnName)
 		stopFunc()
 		delete(c.addonManagers, addOnName)
-		logger.Info("Stopping the manager for addon", "addonName", addOnName)
+		logger.Info("The manager for addon stopped", "addonName", addOnName)
 	}
 	return nil
 }
@@ -249,13 +249,14 @@ func (c *addonTemplateController) runController(ctx context.Context, addonName s
 	kubeInformers.Start(ctx.Done())
 
 	// trigger the manager to reconcile for the existing managed cluster addons
-	mcas, err := c.addonInformers.Addon().V1alpha1().ManagedClusterAddOns().Lister().List(labels.Everything())
+	mcas, err := c.managedClusterAddonIndexer.ByIndex(addonindex.ManagedClusterAddonByName, addonName)
 	if err != nil {
-		logger.Info("Failed to list ManagedClusterAddOns", "error", err)
+		logger.Info("Failed to list ManagedClusterAddOns by index", "error", err)
 	} else {
 		for _, mca := range mcas {
-			if mca.Name == addonName {
-				mgr.Trigger(mca.Namespace, addonName)
+			addon, ok := mca.(*addonv1alpha1.ManagedClusterAddOn)
+			if ok {
+				mgr.Trigger(addon.Namespace, addonName)
 			}
 		}
 	}

pkg/addon/controllers/addontemplate/controller_test.go

@@ -25,8 +25,8 @@ import (
 	fakework "open-cluster-management.io/api/client/work/clientset/versioned/fake"
 	workinformers "open-cluster-management.io/api/client/work/informers/externalversions"
 
-	testingcommon "open-cluster-management.io/ocm/pkg/common/testing"
 	addonindex "open-cluster-management.io/ocm/pkg/addon/index"
+	testingcommon "open-cluster-management.io/ocm/pkg/common/testing"
 	testinghelpers "open-cluster-management.io/ocm/pkg/registration/helpers/testing"
 )
 

test/e2e/addonmanagement_test.go

@@ -5,7 +5,6 @@ import (
 	"embed"
 	"encoding/json"
 	"fmt"
-	"time"
 
 	ginkgo "github.com/onsi/ginkgo/v2"
 	"github.com/onsi/gomega"
@@ -878,7 +877,7 @@ var _ = ginkgo.Describe("Enable addon management feature gate", ginkgo.Ordered,
 				return err
 			}
 			return fmt.Errorf("the configmap should be deleted")
-		}, time.Second*180, time.Second*5).ShouldNot(gomega.HaveOccurred())
+		}).ShouldNot(gomega.HaveOccurred())
 
 		ginkgo.By("ManagedClusterAddon should eventually be deleted after pre-delete job completes")
 		gomega.Eventually(func() error {