Skip to content

Commit 9ef32c1

Browse files
author
mike.wq
committed
Merge branch 'bugfix/remove_connect_retry'
2 parents 50d582f + 4e78c77 commit 9ef32c1

File tree

13 files changed

+17
-20
lines changed

13 files changed

+17
-20
lines changed

app-stream-api/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<parent>
66
<artifactId>open-app-stream-client</artifactId>
77
<groupId>com.dingtalk.open</groupId>
8-
<version>1.3.2</version>
8+
<version>1.3.3</version>
99
<relativePath>../pom.xml</relativePath>
1010
</parent>
1111
<modelVersion>4.0.0</modelVersion>

app-stream-client/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@
44
<parent>
55
<groupId>com.dingtalk.open</groupId>
66
<artifactId>open-app-stream-client</artifactId>
7-
<version>1.3.2</version>
7+
<version>1.3.3</version>
88
<relativePath>../pom.xml</relativePath>
99
</parent>
1010

1111
<artifactId>app-stream-client</artifactId>
1212
<packaging>jar</packaging>
13-
<version>1.3.2</version>
13+
<version>1.3.3</version>
1414
<name>app-stream-client</name>
1515

1616
<dependencies>

app-stream-network/app-stream-network-api/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@
44
<parent>
55
<groupId>com.dingtalk.open</groupId>
66
<artifactId>app-stream-network</artifactId>
7-
<version>1.3.2</version>
7+
<version>1.3.3</version>
88
<relativePath>../pom.xml</relativePath>
99
</parent>
1010

1111
<artifactId>app-stream-network-api</artifactId>
12-
<version>1.3.2</version>
12+
<version>1.3.3</version>
1313
<packaging>jar</packaging>
1414

1515
<name>app-stream-network-api</name>

app-stream-network/app-stream-network-core/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<parent>
55
<groupId>com.dingtalk.open</groupId>
66
<artifactId>app-stream-network</artifactId>
7-
<version>1.3.2</version>
7+
<version>1.3.3</version>
88
<relativePath>../pom.xml</relativePath>
99
</parent>
1010

app-stream-network/app-stream-network-core/src/main/java/com/dingtalk/open/app/stream/network/core/DefaultSessionPool.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,8 +165,7 @@ public void run() {
165165
closeSession(previous.getId());
166166
}
167167
}
168-
Session session = new RetryRunner<Session>(MAX_RETRY_COUNT, new ExponentialBackoffPolicy())
169-
.run(() -> Connector.connect(connection, new TransportConnectionListener(), connectionTimeout, connectionTTL, keepAliveIdle));
168+
Session session = Connector.connect(connection, new TransportConnectionListener(), connectionTimeout, connectionTTL, keepAliveIdle);
170169
if (session == null) {
171170
return;
172171
}

app-stream-network/app-stream-network-rsocket/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<parent>
55
<groupId>com.dingtalk.open</groupId>
66
<artifactId>app-stream-network</artifactId>
7-
<version>1.3.2</version>
7+
<version>1.3.3</version>
88
<relativePath>../pom.xml</relativePath>
99
</parent>
1010

app-stream-network/app-stream-network-ws/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<parent>
55
<groupId>com.dingtalk.open</groupId>
66
<artifactId>app-stream-network</artifactId>
7-
<version>1.3.2</version>
7+
<version>1.3.3</version>
88
<relativePath>../pom.xml</relativePath>
99
</parent>
1010

app-stream-network/app-stream-network-ws/src/main/java/com/dingtalk/open/app/stream/network/ws/KeepAliveHandler.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,13 @@
3131
public class KeepAliveHandler extends SimpleChannelInboundHandler<PongWebSocketFrame> {
3232
private static final InternalLogger LOGGER = InternalLoggerFactory.getLogger(KeepAliveHandler.class);
3333
private final Duration timeout;
34-
private final HashedWheelTimer timer;
34+
private final static HashedWheelTimer TIMER = new HashedWheelTimer();
3535
private Channel channel;
3636
private final Map<String, Timeout> timeouts;
3737
private final AtomicBoolean active;
3838

3939
public KeepAliveHandler(Duration timeout) {
4040
this.timeout = timeout;
41-
this.timer = new HashedWheelTimer();
4241
this.active = new AtomicBoolean(false);
4342
this.timeouts = new ConcurrentHashMap<>();
4443
}
@@ -82,7 +81,6 @@ private void shutdown() {
8281
entry.getValue().cancel();
8382
it.remove();
8483
}
85-
this.timer.stop();
8684
}
8785

8886
private class PingTask implements Runnable {
@@ -96,7 +94,7 @@ public void run() {
9694
PingWebSocketFrame frame = new PingWebSocketFrame(byteBuf);
9795
channel.writeAndFlush(frame).addListener(future -> {
9896
if (future.isSuccess()) {
99-
Timeout pingTimeout = timer.newTimeout(timeout -> {
97+
Timeout pingTimeout = TIMER.newTimeout(timeout -> {
10098
LOGGER.warn("[DingTalk] connection ping timeout, channel is closing");
10199
timeouts.remove(seq);
102100
channel.close();

app-stream-network/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<parent>
66
<artifactId>open-app-stream-client</artifactId>
77
<groupId>com.dingtalk.open</groupId>
8-
<version>1.3.2</version>
8+
<version>1.3.3</version>
99
<relativePath>../pom.xml</relativePath>
1010
</parent>
1111
<packaging>pom</packaging>

app-stream-protocol/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<parent>
77
<groupId>com.dingtalk.open</groupId>
88
<artifactId>open-app-stream-client</artifactId>
9-
<version>1.3.2</version>
9+
<version>1.3.3</version>
1010
</parent>
1111

1212
<artifactId>app-stream-protocol</artifactId>

0 commit comments

Comments
 (0)