Skip to content

Commit 54cf749

Browse files
committed
Improve JCTools test
1 parent dd7d654 commit 54cf749

File tree

1 file changed

+7
-4
lines changed
  • sdk/trace-shaded-deps/src/test/java/io/opentelemetry/sdk/trace/internal

1 file changed

+7
-4
lines changed

sdk/trace-shaded-deps/src/test/java/io/opentelemetry/sdk/trace/internal/JcToolsTest.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ void drain_ArrayBlockingQueue() {
4343
void drain_MessagePassingQueue() {
4444
// Arrange
4545
batch.add("Test3");
46-
Queue<String> queue = new MpscArrayQueue<>(10);
46+
Queue<String> queue = JcTools.newFixedSizeQueue(10);
4747
queue.add("Test1");
4848
queue.add("Test2");
4949

@@ -58,7 +58,7 @@ void drain_MessagePassingQueue() {
5858
@Test
5959
void drain_MaxBatch() {
6060
// Arrange
61-
Queue<String> queue = new MpscArrayQueue<>(10);
61+
Queue<String> queue = JcTools.newFixedSizeQueue(10);
6262
queue.add("Test1");
6363
queue.add("Test2");
6464

@@ -79,7 +79,10 @@ void newFixedSize_MpscQueue() {
7979
Queue<Object> objects = JcTools.newFixedSizeQueue(capacity);
8080

8181
// Assert
82-
assertThat(objects).isInstanceOf(MpscArrayQueue.class);
82+
assertThat(objects)
83+
.satisfiesAnyOf(
84+
queue -> assertThat(queue).isInstanceOf(MpscArrayQueue.class),
85+
queue -> assertThat(queue).isInstanceOf(ArrayBlockingQueue.class));
8386
}
8487

8588
@Test
@@ -92,7 +95,7 @@ void capacity_MpscQueue() {
9295
long queueSize = JcTools.capacity(queue);
9396

9497
// Assert
95-
assertThat(queueSize).isGreaterThan(capacity);
98+
assertThat(queueSize).isGreaterThanOrEqualTo(capacity);
9699
}
97100

98101
@Test

0 commit comments

Comments
 (0)