feat: Publish docker image of reference implementation #785
nickevansuk
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
openactive-test-suite.yml
on: pull_request
build-and-push-docker-image
11s
Matrix: core
Matrix: framework
deploy-reference-implementation
0s
Annotations
6 errors and 12 warnings
|
build-and-push-docker-image
The run was canceled by @nickevansuk.
|
|
build-and-push-docker-image
The operation was canceled.
|
|
test-fake-database
The run was canceled by @nickevansuk.
|
|
test-fake-database
The operation was canceled.
|
|
test-server
The run was canceled by @nickevansuk.
|
|
test-server
The operation was canceled.
|
|
test-fake-database
The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIcon'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl
|
|
test-fake-database
The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIcon'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl
|
|
test-server
The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIcon'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl
|
|
test-server:
OpenActive.Server.NET/CustomBookingEngine/CustomBookingEngine.cs#L153
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
test-server:
OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs#L38
Avoid empty interfaces
|
|
test-server:
OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs#L266
Exceptions should be public
|
|
test-server:
OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs#L266
Add the following constructor to SilentRollbackException: public SilentRollbackException(string message).
|
|
test-server:
OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs#L266
Add the following constructor to SilentRollbackException: public SilentRollbackException(string message, Exception innerException).
|
|
test-server:
OpenActive.Server.NET/OpenBookingHelper/Stores/IdempotencyStore.cs#L22
Member CalculateIdempotencyKey does not access instance data and can be marked as static (Shared in VisualBasic)
|
|
test-server:
OpenActive.Server.NET/OpenBookingHelper/Stores/IdempotencyStore.cs#L23
In externally visible method 'string IdempotencyStore.CalculateIdempotencyKey(OrderIdComponents orderId, string orderJson)', validate parameter 'orderId' is non-null before using it. If appropriate, throw an ArgumentNullException when the argument is null or add a Code Contract precondition asserting non-null argument.
|
|
test-server:
OpenActive.Server.NET/OpenBookingHelper/Async/AsyncDuplicateLock.cs#L36
Call System.IDisposable.Dispose on object created by 'new SemaphoreSlim(1, 1)' before all references to it are out of scope.
|
|
test-server:
OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs#L365
Consider calling ConfigureAwait on the awaited task
|