fix: Prevent slash command popup from activating on invalid inputs

[448523760]

Slash Command popup issue

#7659

When recalling history, the composer(codex_tui::bottom_pane::chat_composer) restores the previous prompt text (which may start with /) and then calls sync_command_popup. The logic in sync_command_popup treats any first line that starts with / and has the caret inside the initial /name token as an active slash command name:

let is_editing_slash_command_name = if first_line.starts_with('/') && caret_on_first_line {
    let token_end = first_line
        .char_indices()
        .find(|(_, c)| c.is_whitespace())
        .map(|(i, _)| i)
        .unwrap_or(first_line.len());
    cursor <= token_end
} else {
    false
};

This detection does not distinguish between an actual interactive slash command being typed and a normal historical prompt that happens to begin with /. As a result, after history recall, the restored prompt like / test is interpreted as an "editing command name" context and the slash-command popup is (re)activated. Once active_popup is ActivePopup::Command, subsequent Up key presses are handled by handle_key_event_with_slash_popup instead of handle_key_event_without_popup, so they no longer trigger history.navigate_up(...) and the session prompt history cannot be scrolled.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[etraut-openai]

Please remove this file from the PR.

[etraut-openai]

I don't think a test is needed in this case because there's little chance of a regression. We're trying to keep our CI test times from exploding, so we want to add tests only when they matter. Please remove.

[etraut-openai]

Thanks for the contribution. I'm not that familiar with the code you're changing here, so I will ask a colleague to review the change. Before I pass it along for review, please address the comments I added.