on Windows, disable `std::byte` with `#define _HAS_STD_BYTE 0`

[2bbb]

Since C++17 introduced std::byte, errors have been occurring frequently on Windows. The best solution would be to avoid using using namespace std; indiscriminately, but I also understand that various addons can cause issues.

So, while it might lead to some confusion, how about defining #define _HAS_STD_BYTE 0 in the VC++ environment to temporarily disable std::byte?
At the very least, beginners and learners around me seem to have developed a fear of recent versions of oF due to these errors, so I think this could serve as a reasonable temporary workaround. I don’t see much code that actually uses std::byte anyway…

That said, I haven’t thoroughly checked whether there are libraries that depend on std::byte, but for now, this is just a suggestion.

[dimitre]

I don't use much windows, but I remember seeing this issue and working on a PR (unmerged) to change the order of includes here
https://github.com/openframeworks/openFrameworks/pull/8000/files
or using a define called WIN32_LEAN_AND_MEAN to avoid unnecessary includes

[ofTheo]

@2bbb - Thanks for posting this.

@dimitre - I think that PR could be okay to merge. @2bbb do you want to test #8000 and see if that fixes it?
Otherwise I think a PR which adds that macro might be a good idea.

[danoli3]

Yeah I just avoid using namespace std; I thought that was go recently

https://cplusplus.com/forum/general/282167/

what VS version and what SDK installed?

[danoli3]

I will be adding a conversion for older projects in oF upgrade addons/src that should disable namespace std; and sed replace any common uses to add std::buffer etc and includes if needed.

been running bots on a thousand projects and 200 or so are broken due to namespace issues

[2bbb]

@dimitre @ofTheo

Sorry, I wasn’t using the latest master branch.
Now that I checked, it seems that at least the byte issue has been resolved in the master branch.
So, I will close this issue for now.

As for the #define OF_USE_MINIMAL_STD macro, I feel like there might be a better way to write it, so I will submit a PR later.

[ofTheo]

Thanks at @2bbb !!