🐛(back) fix document filename handling for documents stored on AWS

The document serializer was not properly updated in the previous PR.
When serving legacy Marsha documents that were stored on AWS (now migrated to
Scaleway), the filename was still computed from playlist and document titles.
It should instead use the newly added filename field.
Fixing that behavior.

Author: wilbrdt

CHANGELOG.md

@@ -8,6 +8,10 @@ Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
 
+### Fixed
+
+- Fix filename handling for legacy documents
+
 ## [5.11.0] - 2025-07-17
 
 ### Changed

src/backend/marsha/core/serializers/file.py

@@ -87,10 +87,7 @@ def get_filename(self, obj):
             The document's filename
 
         """
-        if obj.storage_location == SCW_S3:
-            return obj.filename
-
-        return self._get_filename(obj.title, obj.extension, obj.playlist.title)
+        return obj.filename
 
     def get_url(self, obj):
         """Url of the Document.

src/backend/marsha/core/tests/test_api_document.py

@@ -63,6 +63,7 @@ def test_api_document_fetch_instructor_on_aws(self):
             pk="4c51f469-f91e-4998-b438-e31ee3bd3ea6",
             uploaded_on=datetime(2018, 8, 8, tzinfo=baseTimezone.utc),
             upload_state="ready",
+            filename="bar_baz.pdf",
             extension="pdf",
             playlist__title="foo",
             playlist__lti_id="course-v1:ufr+mathematics+00001",
@@ -83,13 +84,13 @@ def test_api_document_fetch_instructor_on_aws(self):
             {
                 "active_stamp": "1533686400",
                 "extension": "pdf",
-                "filename": "foo_bar-baz.pdf",
+                "filename": "bar_baz.pdf",
                 "id": str(document.id),
                 "is_ready_to_show": True,
                 "title": document.title,
                 "upload_state": "ready",
                 "url": "https://abc.svc.edge.scw.cloud/aws/4c51f469-f91e-4998-b438-e31ee3bd3ea6/"
-                "document/foo_bar-baz.pdf",
+                "document/bar_baz.pdf",
                 "show_download": True,
                 "playlist": {
                     "id": str(document.playlist.id),

src/backend/marsha/core/tests/views/test_public_document.py

@@ -37,6 +37,7 @@ def test_document_publicly_accessible_on_aws(self):
             playlist__consumer_site__domain="trusted_domain.com",
             is_public=True,
             title="document-001",
+            filename="document-001.pdf",
             upload_state=random.choice([s[0] for s in STATE_CHOICES]),
             uploaded_on="2019-09-24 07:24:40+00",
             storage_location=AWS_S3,
@@ -79,15 +80,15 @@ def test_document_publicly_accessible_on_aws(self):
                 "upload_state": document.upload_state,
                 "title": document.title,
                 "extension": None,
-                "filename": "playlist-003_document-001",
+                "filename": "document-001.pdf",
                 "playlist": {
                     "id": str(document.playlist.id),
                     "title": "playlist-003",
                     "lti_id": "course-v1:ufr+mathematics+00001",
                 },
                 "url": (
                     "https://abc.svc.edge.scw.cloud/aws/301b5f4f-b9f1-4a5f-897d-f8f1bf22c396"
-                    "/document/playlist-003_document-001"
+                    "/document/document-001.pdf"
                 ),
             },
         )
@@ -206,6 +207,7 @@ def test_public_document_without_consumer_site(self):
             playlist=playlist,
             is_public=True,
             title="document-001",
+            filename="document-001.pdf",
             upload_state=random.choice([s[0] for s in STATE_CHOICES]),
             uploaded_on="2019-09-24 07:24:40+00",
             storage_location=AWS_S3,
@@ -243,15 +245,15 @@ def test_public_document_without_consumer_site(self):
                 "upload_state": document.upload_state,
                 "title": document.title,
                 "extension": None,
-                "filename": "playlist-003_document-001",
+                "filename": "document-001.pdf",
                 "playlist": {
                     "id": str(document.playlist.pk),
                     "title": "playlist-003",
                     "lti_id": None,
                 },
                 "url": (
                     f"https://abc.svc.edge.scw.cloud/aws/{document.pk}"
-                    "/document/playlist-003_document-001"
+                    "/document/document-001.pdf"
                 ),
             },
         )

src/backend/marsha/development/api.py

@@ -12,7 +12,6 @@
 from marsha.bbb.models import ClassroomDocument
 from marsha.core.defaults import TMP_STORAGE_BASE_DIRECTORY
 from marsha.core.models import Document, Video
-from marsha.core.serializers.file import DocumentSerializer
 from marsha.core.storage.storage_class import file_storage
 from marsha.core.utils import time_utils
 from marsha.deposit.models import DepositedFile
@@ -83,8 +82,7 @@ def local_document_upload(request: HttpRequest, uuid=None):
     except Document.DoesNotExist:
         return Response({"success": False}, status=404)
 
-    filename = DocumentSerializer().get_filename(document)
-    destination = document.get_storage_key(filename=filename)
+    destination = document.get_storage_key(filename=document.filename)
 
     file_storage.save(destination, uploaded_document)
     return Response(status=204)