Skip to content

8362659: Remove sun.print.PrintJob2D.finalize() #26398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Jul 18, 2025

Remove sun.print.PrintJob2D.finalize() - it duplicates the super class finalize()
See the bug report for additional info.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8362659: Remove sun.print.PrintJob2D.finalize() (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26398/head:pull/26398
$ git checkout pull/26398

Update a local copy of the PR:
$ git checkout pull/26398
$ git pull https://git.openjdk.org/jdk.git pull/26398/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26398

View PR using the GUI difftool:
$ git pr show -t 26398

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26398.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 18, 2025

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 18, 2025

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362659: Remove sun.print.PrintJob2D.finalize()

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8362659 8362659: Remove sun.print.PrintJob2D.finalize() Jul 18, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 18, 2025
@openjdk
Copy link

openjdk bot commented Jul 18, 2025

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jul 18, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 19, 2025
@prrace
Copy link
Contributor Author

prrace commented Jul 21, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jul 21, 2025

Going to push as commit b8da969.
Since your change was applied there have been 45 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 21, 2025
@openjdk openjdk bot closed this Jul 21, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 21, 2025
@openjdk
Copy link

openjdk bot commented Jul 21, 2025

@prrace Pushed as commit b8da969.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants