fix: remove prepending and appending runes to the condition type and reason (#177)

* fix: remove the preprending and appendig to condition type and reason

* feat: release v0.23.4

* format

Author: reshnm

VERSION

@@ -1 +1 @@
-v0.23.3-dev
+v0.23.4

go.mod

@@ -11,7 +11,7 @@ require (
 	github.com/google/uuid v1.6.0
 	github.com/onsi/ginkgo/v2 v2.27.2
 	github.com/onsi/gomega v1.38.2
-	github.com/openmcp-project/controller-utils/api v0.23.3
+	github.com/openmcp-project/controller-utils/api v0.23.4
 	github.com/spf13/pflag v1.0.10
 	github.com/stretchr/testify v1.11.1
 	go.uber.org/zap v1.27.0

pkg/conditions/updater.go

@@ -290,7 +290,8 @@ func ReplaceIllegalCharsInConditionType(s string) string {
 			result = append(result, '_')
 		}
 	}
-	return ensureStartsAndEndsWithLetter(string(result), 'T', 't')
+
+	return string(result)
 }
 
 // ReplaceIllegalCharsInConditionReason replaces all characters in the given string that are not allowed in condition reasons with underscores.
@@ -320,21 +321,6 @@ func ReplaceIllegalCharsInConditionReason(s string) string {
 			result = append(result, '_')
 		}
 	}
-	return ensureStartsAndEndsWithLetter(string(result), 'R', 'r')
-}
 
-func ensureStartsAndEndsWithLetter(s string, start, end rune) string {
-	if s == "" {
-		return s
-	}
-	runes := []rune(s)
-	// Ensure starts with letter
-	if (runes[0] < 'a' || runes[0] > 'z') && (runes[0] < 'A' || runes[0] > 'Z') {
-		runes = append([]rune{start}, runes...)
-	}
-	// Ensure ends with letter
-	if (runes[len(runes)-1] < 'a' || runes[len(runes)-1] > 'z') && (runes[len(runes)-1] < 'A' || runes[len(runes)-1] > 'Z') {
-		runes = append(runes, end)
-	}
-	return string(runes)
+	return string(result)
 }

pkg/controller/status_updater_test.go

@@ -128,10 +128,10 @@ var _ = Describe("Status Updater", func() {
 		}
 		condFunc := controller.GenerateCreateConditionFunc(rr)
 
-		condFunc("0CondType :,;-_.Test02@", metav1.ConditionTrue, "1Reason -.,:_Test93$", "Message")
+		condFunc("CondType :,;-_.Test02@", metav1.ConditionTrue, "Reason -.,:_Test93$", "Message")
 		Expect(rr.Conditions).To(HaveLen(1))
-		Expect(rr.Conditions[0].Type).To(Equal("T0CondType____-_.Test02_t"))
-		Expect(rr.Conditions[0].Reason).To(Equal("R1Reason___,:_Test93_r"))
+		Expect(rr.Conditions[0].Type).To(Equal("CondType____-_.Test02_"))
+		Expect(rr.Conditions[0].Reason).To(Equal("Reason___,:_Test93_"))
 	})
 
 	It("should not update disabled fields", func() {