Add parser for Java 25

[Laurens-W]

What problem are you trying to solve?

Prepare for Java 25 being released later this year

Describe the solution you'd like

With Java 25 being a LTS version it warrants a rewrite-java-25 module

Additional context

https://openjdk.org/projects/jdk/25/

Are you interested in contributing this feature to OpenRewrite?

[timtebeek]

Thanks for logging the issue! Traditionally we've created new parsers by copying the most recent one, and then working from there. Here's a quick outline of steps

• Copy rewrite-java-21 to rewrite-java-25
• Override the java_version in ci.yml using with:
• adjust IDE.properties.tmp to also include rewrite-java-25
• Remove the UnknownType reference from the Java 25 parser
• Add a @MinimumJava25 annotation for use in tests
• Update settings.gradle to add rewrite-java-25 there

[timtebeek]

Theoretically we could leverage the newer Class-File API from https://openjdk.org/jeps/484, but that'd be a larger effort, and might then delay support. So for now I'd suggest we start without that, with an eye to evaluate the benefits once available for future Java versions.

[gounthar]

What I've observed when running OpenRewrite with JDK25 (on a recipe unrelated to JDK25) is the following error:

        ... 29 more
Caused by: java.lang.NoClassDefFoundError: com/sun/tools/javac/code/Type$UnknownType
        at org.openrewrite.java.isolated.ReloadableJava17TypeMapping.type(ReloadableJava17TypeMapping.java:49)
        at org.openrewrite.java.isolated.ReloadableJava17TypeMapping.type(ReloadableJava17TypeMapping.java:376)
        at org.openrewrite.java.isolated.ReloadableJava17TypeMapping.type(ReloadableJava17TypeMapping.java:366)
        at org.openrewrite.java.isolated.ReloadableJava17ParserVisitor.visitClass(ReloadableJava17ParserVisitor.java:415)
        at org.openrewrite.java.isolated.ReloadableJava17ParserVisitor.visitClass(ReloadableJava17ParserVisitor.java:76)
        at com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:900)
        at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:92)
        at org.openrewrite.java.isolated.ReloadableJava17ParserVisitor.convert(ReloadableJava17ParserVisitor.java:1770)
        ... 27 more
Caused by: java.lang.ClassNotFoundException: com.sun.tools.javac.code.Type$UnknownType
        ... 35 more

[timtebeek]

@gounthar do you have rewrite-java-21 on the classpath when you do so? Or perhaps the rewrite-java-17 that lacks this workaround?

rewrite/rewrite-java-21/src/main/java/org/openrewrite/java/isolated/ReloadableJava21TypeMapping.java

Lines 781 to 786 in 5bc7273

	/**
	* Check for the `UnknownType` which existed up until JDK 22; starting with JDK 23 only the `ErrorType` is used
	*/
	public static boolean isUnknownType(@Nullable Type type) {
	return type != null && type.getClass().getName().equals("com.sun.tools.javac.code.Type$UnknownType");
	}

[gounthar]

I'm supposed to have it in the classpath, as it is part of our dependencies declared in our pom.xml. 🤔

[timtebeek]

Hmm that's odd then; we'll likely learn more as soon as development on Java 25 starts, or when we add a matrix build here for 25-ea.