Skip to content

Conversation

@Gagan6164
Copy link
Contributor

@Gagan6164 Gagan6164 commented Jul 22, 2025

Description

Refactor WarmDiskThresholdDecider and DiskThresholdMonitor to use warm disk usage

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Gagan6164 Gagan6164 requested a review from a team as a code owner July 22, 2025 11:18
@github-actions
Copy link
Contributor

❌ Gradle check result for 3714742: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Gagan Singh Saini <[email protected]>
@github-actions
Copy link
Contributor

✅ Gradle check result for 9f82e86: SUCCESS

@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

❌ Patch coverage is 86.84211% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.88%. Comparing base (2906600) to head (9f82e86).
⚠️ Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
...g/allocation/decider/WarmDiskThresholdDecider.java 86.84% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18808      +/-   ##
============================================
+ Coverage     72.78%   72.88%   +0.10%     
- Complexity    68544    68595      +51     
============================================
  Files          5567     5569       +2     
  Lines        314911   314913       +2     
  Branches      45684    45679       -5     
============================================
+ Hits         229201   229526     +325     
+ Misses        67092    66724     -368     
- Partials      18618    18663      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gbbafna gbbafna merged commit 5fd0a36 into opensearch-project:main Jul 30, 2025
34 of 35 checks passed
sunqijun1 pushed a commit to sunqijun1/OpenSearch that referenced this pull request Aug 4, 2025
tandonks pushed a commit to tandonks/OpenSearch that referenced this pull request Aug 5, 2025
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants