Skip to content

Commit 321c32c

Browse files
Fix missing RAG response from generative_qa_parameters
Signed-off-by: rithin-pullela-aws <[email protected]>
1 parent f75ae1a commit 321c32c

File tree

2 files changed

+20
-7
lines changed

2 files changed

+20
-7
lines changed

plugin/src/main/java/org/opensearch/ml/processor/MLInferenceSearchResponse.java

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import org.opensearch.action.search.SearchResponse;
1111
import org.opensearch.action.search.SearchResponseSections;
1212
import org.opensearch.action.search.ShardSearchFailure;
13+
import org.opensearch.core.xcontent.ToXContent;
1314
import org.opensearch.core.xcontent.XContentBuilder;
1415

1516
public class MLInferenceSearchResponse extends SearchResponse {
@@ -41,16 +42,21 @@ public Map<String, Object> getParams() {
4142
}
4243

4344
@Override
44-
public XContentBuilder toXContent(XContentBuilder builder, Params params) throws IOException {
45-
builder.startObject();
46-
innerToXContent(builder, params);
47-
45+
public XContentBuilder innerToXContent(XContentBuilder builder, ToXContent.Params params) throws IOException {
46+
super.innerToXContent(builder, params);
4847
if (this.params != null) {
4948
builder.startObject(EXT_SECTION_NAME);
5049
builder.field(MLInferenceSearchResponseProcessor.TYPE, this.params);
5150

5251
builder.endObject();
5352
}
53+
return builder;
54+
}
55+
56+
@Override
57+
public XContentBuilder toXContent(XContentBuilder builder, Params params) throws IOException {
58+
builder.startObject();
59+
innerToXContent(builder, params);
5460
builder.endObject();
5561
return builder;
5662
}

search-processors/src/main/java/org/opensearch/searchpipelines/questionanswering/generative/GenerativeSearchResponse.java

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import org.opensearch.action.search.SearchResponse;
2424
import org.opensearch.action.search.SearchResponseSections;
2525
import org.opensearch.action.search.ShardSearchFailure;
26+
import org.opensearch.core.xcontent.ToXContent;
2627
import org.opensearch.core.xcontent.XContentBuilder;
2728

2829
/**
@@ -63,9 +64,8 @@ public GenerativeSearchResponse(
6364
}
6465

6566
@Override
66-
public XContentBuilder toXContent(XContentBuilder builder, Params params) throws IOException {
67-
builder.startObject();
68-
innerToXContent(builder, params);
67+
public XContentBuilder innerToXContent(XContentBuilder builder, ToXContent.Params params) throws IOException {
68+
super.innerToXContent(builder, params);
6969
/* start of ext */ builder.startObject(EXT_SECTION_NAME);
7070
/* start of our stuff */ builder.startObject(GenerativeQAProcessorConstants.RESPONSE_PROCESSOR_TYPE);
7171
if (answer == null) {
@@ -80,6 +80,13 @@ public XContentBuilder toXContent(XContentBuilder builder, Params params) throws
8080
}
8181
/* end of our stuff */ builder.endObject();
8282
/* end of ext */ builder.endObject();
83+
return builder;
84+
}
85+
86+
@Override
87+
public XContentBuilder toXContent(XContentBuilder builder, Params params) throws IOException {
88+
builder.startObject();
89+
innerToXContent(builder, params);
8390
builder.endObject();
8491
return builder;
8592
}

0 commit comments

Comments
 (0)