Commit 82b71a3
committed
feat: add ok-to-test workflow approval for external PRs
This workflow solves the current bottleneck where external contributors must
wait for maintainer approval to run any workflows, including functional tests.
- Problem:
Repository requires approval for all outside collaborators' fork PR workflows.
Therefore, external contributors can't run functional tests until maintainer approval.
Maintainers cannot approve without run functiona tests. This process forces manual local testing
and functional validation, slowing down reviews. So we can't enjoy much from function tests
and other tests in workflows.
In a short, it creates unnecessary friction between PR approval and workflow approval.
- Solution:
Add pr-approve-workflows.yaml to automatically approve pending workflow runs.
Uses pull_request_target with elevated permissions for security and triggers when 'ok-to-test'
label is added, separating PR review from workflow approval.
This enables external contributors to run functional tests immediately after
maintainer adds the ok-to-test label, significantly reducing review time and
eliminating the need for manual local testing.
This pattern is widely used in other opensource projects.
Signed-off-by: josedev-union <[email protected]>1 parent 9b10349 commit 82b71a3
1 file changed
+42
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
0 commit comments