[Backport 2.19-dev] Merge the implementation of timechart and chart (#4755)
#4796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct#4755) * Remove visitTimechart Signed-off-by: Yuanchun Shen <[email protected]> * Migrate per functions to Chart Signed-off-by: Yuanchun Shen <[email protected]> * Update CalcitePPLTimechartTest Signed-off-by: Yuanchun Shen <[email protected]> * Migrate TimecharTest to use Chart Signed-off-by: Yuanchun Shen <[email protected]> * Fix AST relevant tests Signed-off-by: Yuanchun Shen <[email protected]> * Remove Timechart AST object in favor of Chart Signed-off-by: Yuanchun Shen <[email protected]> * Update expected plans for timechart Signed-off-by: Yuanchun Shen <[email protected]> * Update doctest for timechart - add 2 more indicies for test purpose Signed-off-by: Yuanchun Shen <[email protected]> * Add yaml tests for 4581, 4582, and 4632 Signed-off-by: Yuanchun Shen <[email protected]> * Allow flexible parameter positions for chart and timechart Signed-off-by: Yuanchun Shen <[email protected]> * Simplify CalciteTimechartCommandIT Signed-off-by: Yuanchun Shen <[email protected]> --------- Signed-off-by: Yuanchun Shen <[email protected]> (cherry picked from commit daf1795)
LantaoJin
approved these changes
Nov 13, 2025
LantaoJin
requested review from
GumpacG,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
qianheng-aws
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #4755 to 2.19-dev
(cherry picked from commit daf1795)
Commit Message
Remove visitTimechart
Migrate per functions to Chart
Update CalcitePPLTimechartTest
Migrate TimecharTest to use Chart
Fix AST relevant tests
Remove Timechart AST object in favor of Chart
Update expected plans for timechart
Update doctest for timechart
Add yaml tests for 4581, 4582, and 4632
Allow flexible parameter positions for chart and timechart
Simplify CalciteTimechartCommandIT
Related Issues
Resolves #4581, resolves #4582, resolves #4632
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.